Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] crm_event: Migration to version 15.0 #294

Merged
merged 12 commits into from
Feb 24, 2023

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT41008

@chienandalu @CarlosRoca13 please review!

Jairo Llopis and others added 11 commits January 12, 2023 12:07
This module extends the functionality of CRM opportunities (and leads, if
enabled) to support linking them to event types and to allow you to keep track
of leads interested in an upcoming event of some type.

This is useful if you organize your events based on the amount of people
interested in a certain type of event.

@Tecnativa TT27664

[UPD] Update crm_event.pot

[UPD] README.rst

[ADD] icon.png
- Upstream merged both lead and opportunity form views.

@Tecnativa TT31318
It complies with the requirements and is needed by manifestoo.
The company field isn't mandatory for event types, so we have to check
that a lead auto invites to events available in the company of the lead.

We also have to check the proper base_url for our template. When we have
multi-website we want our customer going to the right link, otherwise
they'd be getting confusing info.

TT36027
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-crm_event branch 2 times, most recently from 33996a7 to c589951 Compare January 23, 2023 09:50
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the translations of es.po

Comment on lines 59 to 82
msgid "Event Template"
msgstr "Categoría de eventos"

#. module: crm_event
#: model:ir.model,name:crm_event.model_event_type_report
#, fuzzy
#| msgid "Event category"
msgid "Event categories analysis report"
msgstr "Categoría de evento"

#. module: crm_event
#: model:ir.model.fields,field_description:crm_event.field_crm_lead__event_type_id
msgid "Event category"
msgstr "Categoría de evento"

#. module: crm_event
#: model:ir.actions.act_window,name:crm_event.action_event_type_report
#: model_terms:ir.ui.view,arch_db:crm_event.view_event_type_report_graph
#: model_terms:ir.ui.view,arch_db:crm_event.view_event_type_report_pivot
#: model_terms:ir.ui.view,arch_db:crm_event.view_event_type_report_search
#, fuzzy
#| msgid "Event category"
msgid "Event category analysis"
msgstr "Categoría de evento"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review translations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for notifying me

crm_event/i18n/es.po Outdated Show resolved Hide resolved
crm_event/i18n/es.po Outdated Show resolved Hide resolved
crm_event/i18n/es.po Outdated Show resolved Hide resolved
crm_event/i18n/es.po Outdated Show resolved Hide resolved
crm_event/i18n/es.po Outdated Show resolved Hide resolved
crm_event/i18n/es.po Outdated Show resolved Hide resolved
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @stefan-tecnativa 👍

@pedrobaeza
Copy link
Member

/ocabot migration crm_event
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 24, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 24, 2023
16 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-294-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bcc0def into OCA:15.0 Feb 24, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ec578be. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants