Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] event_sale_reservation: Migration to 15.0 #296

Merged
merged 5 commits into from
Feb 14, 2023
Merged

[15.0][MIG] event_sale_reservation: Migration to 15.0 #296

merged 5 commits into from
Feb 14, 2023

Conversation

victoralmau
Copy link
Member

Migration to 15.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT41011

@pedrobaeza
Copy link
Member

/ocabot migration event_sale_reservation

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 27, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 27, 2023
Open
16 tasks
Jairo Llopis and others added 4 commits February 13, 2023 10:39
@victoralmau
[ADD] event_sale_reservation: sell events before they exist
dbcbd84 
This module extends the functionality of event_sale to support selling
reservations of events that still don't exist and to allow you to schedule the
creation of events based on how many reservations already exist.

Includes integration workaround to avoid test conflicts with
`event_sale_registration_multi_qty`.

@Tecnativa TT27664

[UPD] Update event_sale_reservation.pot

[UPD] README.rst
@victoralmau
[IMP] event_sale_reservation: black, isort, prettier
52d491d
@victoralmau
[MIG] event_sale_reservation: Migration to 13.0
d1a6a37 
TT31321

[UPD] Update event_sale_reservation.pot

[UPD] README.rst
@victoralmau
[IMP] event_sale_reservation: black, isort, prettier
1175dfd
@victoralmau victoralmau force-pushed the 15.0-mig-event_sale_reservation branch from 087c799 to 74f21e8 Compare February 13, 2023 10:10
@victoralmau
Copy link
Member Author

Changes done.

chienandalu
chienandalu approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍 Just two readme suggestions:

event_sale_reservation/readme/USAGE.rst Outdated Show resolved Hide resolved
event_sale_reservation/readme/USAGE.rst Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 15.0-mig-event_sale_reservation branch from 74f21e8 to 6c20f72 Compare February 14, 2023 09:13
pedrobaeza
pedrobaeza approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

event_sale_reservation/migrations/15.0.1.0.0/post-migration.py Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-296-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 14, 2023
@OCA-git-bot
Merge PR #296 into 15.0
df2850e 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-296-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit da871ae into OCA:15.0 Feb 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3bb5045. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu