-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] event_registration_partner_unique: Migration to version 15.0 #301
[15.0][MIG] event_registration_partner_unique: Migration to version 15.0 #301
Conversation
This module allows you to avoid having a partner registrated twice in the same event.
It has to declare unique indexes instead of constraints to work. [1]: OCA#38 (comment)
- Remove dependency on event_sale. - Add custom field that allows to choose in which events to disable duplicates. - Add tests. - Add custom exception to be used in upcoming submodule (for event_sale).
- Updated views - Updated README
Currently translated at 100.0% (5 of 5 strings) Translation: event-13.0/event-13.0-event_registration_partner_unique Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-event_registration_partner_unique/es/
Steps to reproduce the problem: - Register anonymously a first attendee for an event from website. - The registration is saved with no attendee_partner_id. - Repeat the registration again anonymously. - You get the error "Duplicated partners found in event...". That's because current duplicated domain is searching for other registrations regardless of if there's a linked partner or not. We now restrict the search to those with a linked partner. TT32961
Currently translated at 75.0% (6 of 8 strings) Translation: event-14.0/event-14.0-event_registration_partner_unique Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_registration_partner_unique/it/
@pedrobaeza @victoralmau please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test and code review. Thanks! 👍
/ocabot migration event_registration_partner_unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 28fe0f7. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT41880