Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] event_registration_partner_unique: Migration to version 15.0 #301

Merged

Conversation

ernesto-garcia-tecnativa

@Tecnativa TT41880

yajo and others added 19 commits March 7, 2023 13:32
This module allows you to avoid having a partner registrated twice in the same event.
It has to declare unique indexes instead of constraints to work.

[1]: OCA#38 (comment)
- Remove dependency on event_sale.
- Add custom field that allows to choose in which events to disable duplicates.
- Add tests.
- Add custom exception to be used in upcoming submodule (for event_sale).
Currently translated at 100.0% (5 of 5 strings)

Translation: event-13.0/event-13.0-event_registration_partner_unique
Translate-URL: https://translation.odoo-community.org/projects/event-13-0/event-13-0-event_registration_partner_unique/es/
Steps to reproduce the problem:

- Register anonymously a first attendee for an event from website.
- The registration is saved with no attendee_partner_id.
- Repeat the registration again anonymously.
- You get the error "Duplicated partners found in event...".

That's because current duplicated domain is searching for other
registrations regardless of if there's a linked partner or not.

We now restrict the search to those with a linked partner.

TT32961
Currently translated at 75.0% (6 of 8 strings)

Translation: event-14.0/event-14.0-event_registration_partner_unique
Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_registration_partner_unique/it/
@ernesto-garcia-tecnativa
Copy link
Author

@pedrobaeza @victoralmau please review

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and code review. Thanks! 👍

@pedrobaeza
Copy link
Member

/ocabot migration event_registration_partner_unique

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 8, 2023
16 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-301-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9d71dbd into OCA:15.0 Mar 8, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28fe0f7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants