Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] event_mail: Migration to version 15.0 #312

Merged
merged 14 commits into from
Jun 13, 2023

Conversation

ernestotejeda
Copy link
Member

Cc @Tecnativa TT42036

Comment on lines 49 to 50
"template_ref": "mail.template, %i"
% self.env.ref("event.event_reminder").id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"template_ref": "mail.template, %i"
% self.env.ref("event.event_reminder").id,
"template_ref": f"mail.template, {self.env.ref("event.event_reminder").id}",

event_mail/tests/test_event_mail.py Outdated Show resolved Hide resolved
@ernestotejeda
Copy link
Member Author

@chienandalu could you review again?

@chienandalu
Copy link
Member

please review @stefan-tecnativa

Copy link
Contributor

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested, LGTM. Just check the comments.

@ernestotejeda
Copy link
Member Author

@stefan-tecnativa changes done

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone :)

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@pedrobaeza
Copy link
Member

/ocabot migration event_mail
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-312-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 13, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 13, 2023
16 tasks
@OCA-git-bot OCA-git-bot merged commit 807e280 into OCA:15.0 Jun 13, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 565517a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet