Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] event_mail: Migration to version 16.0 #316

Merged
merged 16 commits into from
Aug 1, 2023

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT43665

@ernestotejeda @chienandalu please review!

@@ -9,6 +9,7 @@
<xpath expr="//field[@name='event_mail_ids']" position="before">
<field
name="event_mail_template_id"
groups="base.group_user"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to install the module, it gave me an error complaining that
Field 'seats_expected' used in attrs ({'readonly': [('seats_expected', '>', 0)]}) is restricted to the group(s) base.group_user.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks

@pedrobaeza
Copy link
Member

/ocabot migration event_mail
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 1, 2023
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-316-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 20, 2023
14 tasks
OCA-git-bot added a commit that referenced this pull request Aug 1, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-316-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f8a728a into OCA:16.0 Aug 1, 2023
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 838e13c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet