Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] event_sale_registration_multi_qty: Migration to version 16.0 #319

Merged

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT43668

@chienandalu please review!

This PR depends on #318

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chienandalu
Copy link
Member

@CarlosRoca13 please review

@pedrobaeza
Copy link
Member

Please rebase.

@pedrobaeza
Copy link
Member

/ocabot migration event_sale_registration_multi_qty
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 5, 2023
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-319-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 5, 2023
14 tasks
OCA-git-bot added a commit that referenced this pull request Jul 5, 2023
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

Ouch, you haven't removed the latest commit with the temporary dependency.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-319-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@stefan-tecnativa
Copy link
Contributor Author

stefan-tecnativa commented Jul 5, 2023

Ouch, you haven't removed the latest commit with the temporary dependency.

I've removed that commit and pushed, but it seems that is not well updated. Maybe is due to this morning PR problems. I will try again later to see if updates properly.

@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-event_sale_registration_multi_qty branch from 7b6cd3d to 0fc5828 Compare July 5, 2023 12:23
@chienandalu
Copy link
Member

RTM?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-319-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 63470d4 into OCA:16.0 Aug 1, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa0e5ae. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants