[16.0] [MIG] event_contact #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration event_contact |
yajo
approved these changes
Apr 30, 2024
EmilioPascual
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
@edlopen good job migrating this module.
Funciontal and code review.
Shide
approved these changes
Apr 30, 2024
|
@edlopen can you make rebase for run tests again, thank you |
Also it will load the contacts from the event type if the event has none and the type has some.
Document new behavior for event type contacts, and fix its test.
Currently translated at 75.0% (6 of 8 strings) Translation: event-14.0/event-14.0-event_contact Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_contact/it/
Currently translated at 100.0% (8 of 8 strings) Translation: event-14.0/event-14.0-event_contact Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_contact/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-14.0/event-14.0-event_contact Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_contact/
Currently translated at 100.0% (8 of 8 strings) Translation: event-14.0/event-14.0-event_contact Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-event_contact/es/
edlopen
force-pushed
the
16.0-mig-event_contact
branch
from
ff2e42f
to
214ce35
Compare
yajo
requested changes
May 7, 2024
MT-1840
edlopen
force-pushed
the
16.0-mig-event_contact
branch
from
214ce35
to
aa63245
Compare
yajo
approved these changes
May 8, 2024
|
This PR has the |
|
Can you check it functionally @fcvalgar? Thanks! |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 564a431. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to 16.0
MT-1840
@yajo @EmilioPascual @Shide @rafaelbn review this PR when you can.