New module "event_project" #4
Conversation
|
Hey @JavierIniesta, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
You need to put first project_recalculate module (is this the best name? we can discuss it in the corresponding PR). Please also sign the CLA or sign a Corporate CLA for Antiun. Tell @rafaelbn about it. |
|
CLA checked. Next commit will be OK. |
|
@JavierIniesta @antespi which is the status of this PR? |
|
Hey @JavierIniesta, Appreciation of efforts, |
| "website": "http://www.antiun.com", | ||
| "license": "AGPL-3", | ||
| "category": "Event Management", | ||
| "depends": ['base', 'event', 'project'], | ||
| "depends": [ | ||
| 'base', |
antespi
force-pushed
the
pr-event_tasks_integration
branch
from
4e5f640
to
e0c4307
Compare
|
@dreispt done. Squash and rebase. |
| # | ||
| ############################################################################## | ||
| # -*- coding: utf-8 -*- | ||
| # See README.rst file on addon root folder for license details |
There was a problem hiding this comment.
Although I agree it can be shortened, I don't think you can totally remove copyright and license info from individual code files. There is certainly indication for that in the contributing guidelines.
There was a problem hiding this comment.
After reading http://hackerboss.com/get-rid-of-templates/, we decide to indicate license and contributors only in README.rst for centralize maintenance. Is this mandatory?
There was a problem hiding this comment.
The problem is that it's possible to have this file bundled in other code distributions, without some of the other repo files. In this case the reference to the README would be useless.
I've already seen this happen is Odoo, with some js files bundled with it...
|
cc @pedrobaeza, @dreispt, @rafaelbn
Travis error is because |
|
Rebuilding for testing! This module has been in customer's production enviroment for 2 months! Let see what OCA says ;-) cc @janetrp |
|
@antespi, please rebase for getting a correct PR |
|
|
||
| event_id = fields.Many2one( | ||
| comodel_name='event.event', compute='_compute_event', store=True, | ||
| string="Related event", readonly=True) |
There was a problem hiding this comment.
Why is this field needed?
|
To get a green CI you need to add an A rebase is also needed. |
|
Please @JavierIniesta review comments, thanks. |
JavierIniesta
force-pushed
the
pr-event_tasks_integration
branch
from
54dbb64
to
577efa2
Compare
JavierIniesta
force-pushed
the
pr-event_tasks_integration
branch
from
577efa2
to
e8000e0
Compare
|
@antespi @pedrobaeza @dreispt |
Allow multirecord cancelling and fix tests.
This module allows you to plan and organize an Event with a Project related.
Assign a project template to an event, creating the corresponding project for the event that ends on the event start date, and plan the project tasks backwards according a new field "Event anticipation days".
Depends of OCA/project#90