[MIG][event_contact] Migration to v10 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Jun 30, 2017
event_contact/README.rst
Outdated
| the event. Contacts are needed due to inform the people | ||
| who should be contacted for the event | ||
|
|
||
| Installation |
There was a problem hiding this comment.
Remove this obvious instructions that are also referred to 8.0 version (and other people can obtain the module via Apps).
event_contact/README.rst
Outdated
| <https://github.com/OCA/event/issues>`_. In case of trouble, please | ||
| check there if your issue has already been reported. If you spotted it first, | ||
| help us smashing it by providing a detailed and welcomed `feedback | ||
| <https://github.com/OCA/ |
| Contributors | ||
| ------------ | ||
|
|
||
| * Michael Viriyananda <viriyananda.michael@gmail.com> |
event_contact/tests/test_event.py
Outdated
| from openerp.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class SomethingCase(TransactionCase): |
event_contact/models/event.py
Outdated
| self.contact_ids = self.event_type_id.contact_ids | ||
|
|
||
|
|
||
| class EventType(models.Model): |
There was a problem hiding this comment.
Split this in the corresponding file
chienandalu
suggested changes
Jun 30, 2017
event_contact/README.rst
Outdated
|
|
||
| To set contacts to event, you need to: | ||
|
|
||
| #. Go to *Marketing -> Events -> Events*. |
event_contact/README.rst
Outdated
|
|
||
| To set contacts for an event type, you need to: | ||
|
|
||
| #. Go to *Marketing > Configuration > Events > Types of Events*. |
There was a problem hiding this comment.
Events > Configuration > Event Categories
event_contact/README.rst
Outdated
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/199/8.0 |
There was a problem hiding this comment.
event_contact/models/event.py
Outdated
| @api.onchange("event_type_id") | ||
| def _onchange_type_set_contact_ids(self): | ||
| if self.event_type_id.contact_ids and not self.contact_ids: | ||
| self.contact_ids = self.event_type_id.contact_ids |
There was a problem hiding this comment.
Why to check if there are previous contacts assigned to the event? Isn't it better to add those on the event_type to the existing ones?
event_contact/__manifest__.py
Outdated
| @@ -0,0 +1,21 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2016 OpenSynergy Indonesia | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | |||
|
@yajo Looks like your tests are failing |
pedrobaeza
approved these changes
Jul 9, 2017
|
Please squash your 10.0 commits together |
Also it will load the contacts from the event type if the event has none and the type has some.
Document new behavior for event type contacts, and fix its test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa