[RFC] Changes on fsm (recurring) template

[hparfr]

I suggest some changes in v14 at least:

• fsm.template

• rename model fsm.template to fsm.order.template
• company_id: remove default value ([14.0][MIG] fieldservice #740)
• hour : rename field to duration ([14.0][MIG] fieldservice #740)

• fsm.recurring.template

• company_id: remove default value ([14.0][IMP] fieldservice_recurring: adapt to RFC #735 #865)
• frequency_set_id: change required to False ([14.0][IMP] fieldservice_recurring: adapt to RFC #735 #865)
• fsm_order_template_id : remove it [edit]make it optional [/edit] (see product.template) ([14.0][IMP] fieldservice_recurring: adapt to RFC #735 #865)

• product.template:

• fsm_order_template_id: required=False (xml) and invisible if tracking_policy = no ([14.0][IMP] fieldservice_sale: remove required attr in product view #827)
• fsm_recurring_template_id: required=False (xml)

• fsm.recurring:

• frequency_set_id: change required to False ([14.0][IMP] fieldservice_recurring: adapt to RFC #735 #865)

Why ?

• Multicompany: in order to be aligned with product.template, sale.order.template.
• Optional fields: In my use case, I need to set frequencies and duration in the sale_order_lines (a new module soon)
• Having both templates on products: simpler design.
• Optional templates on products: because there is no need of mandatory templates

What do you think of it ?

[hparfr]

ping @brian10048 @max3903 @osi-scampbell

[brian10048]

I only have one objection which is in relation to removing fsm_order_template_id from fsm.recurring.template

* fsm.template

* [ ]  rename model fsm.template to fsm.order.template
* [ ]   `company_id`:  remove default value 
* [ ]  `hour` : rename field to `duration`

These changes to fsm.template sound good to me

* fsm.recurring.template


* [ ]   `company_id`:  remove default value
* [ ]  `frequency_set_id`: change required to False
* [ ]  `fsm_order_template_id` : remove it (see product.template)

First 2 changes are acceptable for me

I don't agree to remove fsm_order_template_id since not all uses of the recurring template come from a product or a sale. For us, we may create a recurring order manually that may not be related to a product at all. We still need the fsm_order_template_id field so that each order from the recurring order is assigned a fsm order template.

* product.template:
* [ ]  `fsm_order_template_id`: required=False (xml) and invisible if tracking_policy = no
* [ ]  `fsm_recurring_template_id`: required=False (xml)

Acceptable

* fsm.recurring:

* [ ]  `frequency_set_id`: change required to False

Acceptable

[hparfr]

I don't agree to remove fsm_order_template_id since not all uses of the recurring template come from a product or a sale. For us, we may create a recurring order manually that may not be related to a product at all. We still need the fsm_order_template_id field so that each order from the recurring order is assigned a fsm order template.

So I suggest then to not remove it, but make it optional.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

[hparfr]

rename model fsm.template to fsm.order.template

Still to do, but low priority for me now.