Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] fieldservice_sale #1041

Closed
wants to merge 78 commits into from

Conversation

epanisset
Copy link
Contributor

No description provided.

@yankinmax
Copy link
Contributor

yankinmax commented Jan 31, 2023

@SilvioC2C this can cause Travis failure not related to this module
ERROR odoo odoo.schema: Table 'fsm_location': unable to set NOT NULL on column 'inventory_location_id'
I suggest to open one more PR to set required attribute directly in view for this field.
If not - LG

@SilvioC2C
Copy link

@yankinmax that shouldn't cause Travis to fail; moreover, that field is defined in fieldservice_stock, not fieldservice_sale.

@yankinmax
Copy link
Contributor

@SilvioC2C I completely agree with you, but modules are installed altogether in the repo, so I had such situations.

@SilvioC2C
Copy link

@yankinmax that's ok, but you should open an issue for that or mention this in the proper PR, this is the wrong place 😄

@yankinmax
Copy link
Contributor

@SilvioC2C I've opened a request on the migration PR for fieldservice_stock:
#993 (comment)

@SilvioC2C SilvioC2C force-pushed the 16.0-mig-fieldservice_sale branch 2 times, most recently from cf2bfcb to e4ca4f6 Compare January 31, 2023 11:20
@max3903 max3903 added this to the 16.0 milestone Jan 31, 2023
@max3903 max3903 self-assigned this Jan 31, 2023
@gurneyalex gurneyalex mentioned this pull request Feb 2, 2023
47 tasks
osi-scampbell and others added 13 commits February 2, 2023 11:30
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM
orders upon sale order confirmation
Added option to install fieldservice_sale module
Added support for selling recurring orders
Travis
Typo, wrong model relationship
Improved values prepation method for recurring
Updated errors on SO smart button for recurring
murtuzasaleh and others added 18 commits February 2, 2023 11:30
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/
Currently translated at 100.0% (32 of 32 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
Currently translated at 100.0% (32 of 32 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (32 of 32 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/de/
Currently translated at 100.0% (32 of 32 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/de/
Currently translated at 100.0% (32 of 32 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
Dependency on migration of fieldservice_account: OCA#1042
Refactoring and fix view errors
Fix view error (obsolete XMLID)
Remove obsolete onchange
Update unit tests
@brian10048
Copy link
Sponsor Contributor

Would you be able to add #1050 in this migration?

Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalonsod
Copy link
Contributor

@epanisset would you resume this PR? In that case, please add #1072 if needed. Thanks!

Copy link

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested 👍️. @epanisset what is the state of this PR?

@pedrobaeza
Copy link
Member

Superseded by #1101, but respecting commit attribution.

@pedrobaeza pedrobaeza closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet