field service team #26

robertrottermann · 2018-10-16T13:29:52Z

Field Service Teams

Teams for managing the field service jobs.

Specifications

A team is a group of field workers
it can have:
- A team leader, and a number of team members.
- Some basic skills a each team member needs
- A minimum size
- A maximum size
Jobs will be assigned to teams.
When we select a team for a job, the available employees will be listed
and can be select from that list to create a crew.
Once an field worker is engaged in a job (crew ?), he cannot be engaged in another job(ongoing)
at the same time.
When he is finished with the current job, he will be available for next job.

changes by the OCA team

…for team and person, customer -person reverse relation,etc

aitorbouzas · 2018-10-16T14:27:15Z

Hi Robert, I just saw your question in the mailing list.

You can edit the name of your PR right here. Click in the three dots at the top right corner of the first commentary in this PR and then click Edit.
To check the runbot error/warning go to the runbot page into your build, then click the gear and read the different logs (note that a warning in the logs also marks the check as failed)
Logs now show:

2018-10-16 13:34:18,128 165 WARNING openerp_test odoo.models: ir.actions.server.create() includes unknown fields: condition

2018-10-16 13:34:18,170 165 WARNING openerp_test odoo.models: ir.ui.menu.write() with unknown fields: load_xmlid

2018-10-16 13:34:18,713 165 WARNING openerp_test odoo.modules.loading: The model fsm.skills has no access rules, consider adding one. E.g. access_fsm_skills,access_fsm_skills,model_fsm_skills,base.group_user,1,0,0,0

To make different commits and then squash them make sure you use this git commands:

For commits:

git commit --all --fixup HEAD

For squashing all your commits automatically:

git rebase -i origin/12.0 --autosquash

robertrottermann · 2018-10-16T14:45:02Z

thanks a lot,
editing of the commit message works fine, but I can not change the title of the PR.
Or can I?
robert

aitorbouzas · 2018-10-16T14:52:49Z

Oh, sure! I told you about the wrong button to edit. There's a button "Edit" at the right of the PR title :)

dreispt · 2018-10-16T22:38:35Z

How do these Teams relate to "Stage Workflows?
Is it expected that different Teams follow different workflow steps?
Can the same Team use different Workflows in two different Jobs?

dreispt · 2018-10-16T22:41:01Z

fsm_team_handler/models/fsm_person_extended.py

+    _inherit = 'res.partner'
+
+    @api.multi
+    def write(self, vals):


I think we don't need this method at all.

What about the case where we need to create a 'person' for an existing 'customer'. Currently, when we create a 'person', a 'customer' will be created and linked with that 'person'. I think the above method will be useful in the reverse process, i.e, creating a 'person' for an existing 'customer'.

That's already described in the specs and implemented:
there is a Wizard to convert a Parnter into a Person: https://github.com/OCA/field-service/blob/11.0/fieldservice/wizard/fsm_wizard.py

dreispt

I would say this intends to implement #5 and #9.

dreispt · 2018-10-16T22:41:29Z

fsm_team_handler/models/res_config_settings_teams.py

+    _inherit = 'res.config.settings'
+
+    group_red_fsm_team = fields.Boolean(
+        string='Manage RedFSM Teams',


dreispt · 2018-10-16T22:43:25Z

fsm_team_handler/models/team_handler.py

+        ('ordinary', 'Ordinary'),
+        ('express', 'Express')],
+            default='ordinary',
+            string="Team Availability"


Deserves a help tooltip explaining the concept.
Why not a Many2one?

…fsmNT

moylop260 · 2018-10-19T16:48:52Z

fsm_team_handler/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-


For python3.5 is not needed use coding magic comment.
Remove this line for all python files.

moylop260 · 2018-10-19T16:49:34Z

fsm_team_handler/__manifest__.py

+{
+    'name': "Field Service Teams",
+    'summary': """Teams for handling the jobs.""",
+    'description': """Jobs can be assigned to a team.


The README.rst file is used instead of this description, then you should delete this description from manifest.

moylop260 · 2018-10-19T16:50:01Z

fsm_team_handler/__manifest__.py

+    'summary': """Teams for handling the jobs.""",
+    'description': """Jobs can be assigned to a team.
+    Members of the team will be handling the work.""",
+    'author': "redO2oo.ch2",


Add to redO2oo.ch2,Odoo Community Association (OCA)

moylop260 · 2018-10-19T16:50:22Z

fsm_team_handler/__manifest__.py

@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+{
+    'name': "Field Service Teams",


license is missing

moylop260 · 2018-10-19T16:51:04Z

fsm_team_handler/models/fsm_person_extended.py

+    _inherit = 'fsm.person'
+
+    available = fields.Boolean(
+            string="Availability",


Use just 4 spaces here instead of 8

moylop260 · 2018-10-19T16:53:18Z

fsm_team_handler/models/team_handler.py

+                # case: team leader(dispatcher)
+                # selecting the teams where
+                # this employee is the leader or member
+                teams = user.fsm_team_ids and\


You can use

teams = (user.fsm_team_ids and user.fsm_team_ids.ids or []) # same spaces previous line

or

teams = user.fsm_team_ids and \ user.fsm_team_ids.ids or [] # 4 spaces

dreispt · 2018-10-21T16:43:11Z

I see a support ticket module being bundled here.
It should be proposed in a separate PR, to have a smaller changesets (PR with big changesets are difficult to review, and so have a hard time to get reviewed; the best approach is an iterative one, "feeding" features for review one at a time).

Also, I would like to discuss the design decisions regarding support tickets, but that's off topic here.

robertrottermann and others added 4 commits October 8, 2018 10:59

REDCOR.md should list redcor enhancements

1a2814f

Merge pull request #1 from OCA/11.0

e46cef2

changes by the OCA team

[ADD] fsm_team_handler. Teams, team members, team type, basic skills …

07ff54e

…for team and person, customer -person reverse relation,etc

[IMP] did some rewording

625ab98

dreispt reviewed Oct 16, 2018

View reviewed changes

lintocybrosys added 2 commits October 17, 2018 12:26

Added access rules for skills, removed reference of red from the code

69acc92

Merge branch 'fsmNT' of https://github.com/redcor/field-service into …

a715e1c

…fsmNT

dreispt mentioned this pull request Oct 17, 2018

Manage Skills: fieldservice_skill #9

Closed

15 tasks

moylop260 requested changes Oct 19, 2018

View reviewed changes

Adding all the modules for testing using travis

8edc53c

lintocybrosys added 3 commits November 5, 2018 14:09

fsm base module added, stage transitions, work sets, work items

007665a

bug fixed: stage transitions

0bf2b06

Travis test completed

ce21970

max3903 added this to the 11.0 milestone Dec 5, 2018

brian10048 mentioned this pull request Jan 18, 2019

[ADD] Team Features #107

Merged

max3903 closed this Jan 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

field service team #26

field service team #26

robertrottermann commented Oct 16, 2018

aitorbouzas commented Oct 16, 2018 •

edited

Loading

robertrottermann commented Oct 16, 2018

aitorbouzas commented Oct 16, 2018

dreispt commented Oct 16, 2018

dreispt Oct 16, 2018

lintocybrosys Oct 17, 2018

dreispt Oct 17, 2018

dreispt left a comment

dreispt Oct 16, 2018

dreispt Oct 16, 2018

moylop260 Oct 19, 2018

moylop260 Oct 19, 2018

moylop260 Oct 19, 2018

moylop260 Oct 19, 2018

moylop260 Oct 19, 2018

moylop260 Oct 19, 2018

dreispt commented Oct 21, 2018

field service team #26

field service team #26

Conversation

robertrottermann commented Oct 16, 2018

Field Service Teams

Specifications

aitorbouzas commented Oct 16, 2018 • edited Loading

robertrottermann commented Oct 16, 2018

aitorbouzas commented Oct 16, 2018

dreispt commented Oct 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt commented Oct 21, 2018

aitorbouzas commented Oct 16, 2018 •

edited

Loading