[ADD][14.0] Add vehicle ownership, linking partners to vehicles #127

[rpsjr]

#127
#126

This PR Add vehicle ownership, linking partners to vehicles.

cc @ivantodorovich @mamcode @sbidoul @mymage @brian10048 @marcelsavegnago @pedrobaeza

[etobella]

Can you squaah your commits in a single one? You can use git rebate in order to do that. Also fix the commit name to [ADD] ...

Last, but not least, you don't need to close and open a new issue. If you use git rebase, you can do it all at once 😉

[mymage]

LGTM for models and views. I don't know if all the file in the root (as .gitignore) are right bat this is a my limit :-(.

[rpsjr]

Can you squaah your commits in a single one? You can use git rebate in order to do that. Also fix the commit name to [ADD] ...

Last, but not least, you don't need to close and open a new issue. If you use git rebase, you can do it all at once 😉

done

[etobella]

Commit message should be [ADD] fleet_vehicle_ownership

Add some tests please

[rpsjr]

Commit message should be [ADD] fleet_vehicle_ownership

Add some tests please

done!

[marcelsavegnago]

@rpsjr Congratulations on the work and thank you very much for your contribution.

[etobella]

You should add self.ensure_one()

[rpsjr]

done

[etobella]

I would recomend to add a default_owner_id = self.id on context

[rpsjr]

done

[etobella]

Once the changes are applied, we can merge. Thanks for the great job 😄

[rpsjr]

What about default owner beeing the company (res.partner) as this is implicit when fleet app is used to HR purooses?

…

On Fri, Nov 24, 2023, 11:38 Enric Tobella ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In fleet_vehicle_ownership/models/res_partner.py <#130 (comment)>: > + def _compute_vehicle_count(self): + for rec in self: + rec.vehicle_count = len(rec.vehicle_ids) + + vehicle_ids = fields.One2many( + "fleet.vehicle", + "owner_id", + required=True, + help="Vehicles owned by this partner", + ) + vehicle_count = fields.Integer( + compute=_compute_vehicle_count, string="Number of Vehicles", store=True + ) + + def action_view_vehicles(self): + xmlid = "fleet.fleet_vehicle_action" You should add self.ensure_one() ------------------------------ In fleet_vehicle_ownership/models/res_partner.py <#130 (comment)>: > + rec.vehicle_count = len(rec.vehicle_ids) + + vehicle_ids = fields.One2many( + "fleet.vehicle", + "owner_id", + required=True, + help="Vehicles owned by this partner", + ) + vehicle_count = fields.Integer( + compute=_compute_vehicle_count, string="Number of Vehicles", store=True + ) + + def action_view_vehicles(self): + xmlid = "fleet.fleet_vehicle_action" + action = self.env["ir.actions.act_window"]._for_xml_id(xmlid) + if self.vehicle_count > 1: I would recomend to add a default_owner_id = self.id on context — Reply to this email directly, view it on GitHub <#130 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCBYEPUWHJWQTHP42QUD3TYGCWP5AVCNFSM6AAAAAA7YIXFQOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBYGA2TMNJYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kaynnan]

[ONLY FUNCTIONAL REVIEW] APPROVED

Vehicle Associate Owner:

Partner (Form Associate a vehicle):

Partner Multiple Vehicles:

[etobella]

What about default owner beeing the company (res.partner) as this is implicit when fleet app is used to HR purooses?

Well, what I am saying is that you are on a partner and clicking the vehicles. From there you can add a new one. Odoo logic says that you are adding a vehicle to the original partner. So it makes sense to do as I say

[rpsjr]

Gotta, I misunderstood the previous msg.

…

On Fri, Nov 24, 2023, 14:12 Enric Tobella ***@***.***> wrote: What about default owner beeing the company (res.partner) as this is implicit when fleet app is used to HR purooses? Well, what I am saying is that you are on a partner and clicking the vehicles. From there you can add a new one. Odoo logic says that you are adding a vehicle to the original partner. So it makes sense to do as I say — Reply to this email directly, view it on GitHub <#130 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCBYEJ62YFK5KFZ775TZ2DYGDIORAVCNFSM6AAAAAA7YIXFQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVHEZTCNRVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[etobella]

So, we can proceed for merge.

Thanks for doing the all the changes 😉

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-130-by-etobella-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 9294ddc. Thanks a lot for contributing to OCA. ❤️