9.0 selection filter #110
Merged
9.0 selection filter #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash a bit the commits? |
pedrobaeza
reviewed
Oct 4, 2016
| @@ -524,6 +573,18 @@ var GeoengineView = View.extend(geoengine_common.GeoengineMixin, { | |||
| }); | |||
| var layerSwitcher = new ol.control.LayerSwitcher({}); | |||
| map.addControl(layerSwitcher); | |||
| /* | |||
|
@pedrobaeza Still work in progress and no I can't squash commits, most of the commits are cherry-pick from #105 |
|
@pedrobaeza BTW target branch is 9.0-ol3 |
|
Yeah, I see, it would be good at the end of the process then |
|
@pedrobaeza still I wanted to keep track of commits done in 8.0 inside 9.0 to show that we are not missing those commits. Here you have few copied commits plus few new commits to port it. |
|
OK, it's not a heavy requirement, but you can see that a not-squashing operation in 8.0 makes now to appear a lot of useless commits. Let's try to make it better in the new 9.0 commits!! |
count selected records instead of features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the selection filter made for geoengine in odoo 8.0 on odoo 9.0 with OL3