[ADD][12.0] google map drawing #289
Conversation
|
Hi @brian10048 If you need help, don't hesitate to let me know |
|
@brian10048 The current module name I'm ok to integrate this in this repository. Can you give it some love to the details to make it compliant with OCA Guidelines? |
brian10048
force-pushed
the
add-google-drawing
branch
5 times, most recently
from
9da09c3
to
2677fc5
Compare
brian10048
force-pushed
the
add-google-drawing
branch
from
2677fc5
to
1074102
Compare
|
@yvaucher I agree I have made minor changes to meet OCA guidelines. Let me know if you see any other specific issues with this and I'll be glad to update |
Update to use google library parameters for URL
| @@ -4,12 +4,13 @@ | |||
| <t t-set="google_maps_api_key" t-value="request.env['ir.config_parameter'].sudo().get_param('google.api_key_geocode')"/> | |||
| <t t-set="google_maps_lang_localization" t-value="request.env['ir.config_parameter'].sudo().get_param('google.lang_localization')"/> | |||
| <t t-set="google_maps_region_localization" t-value="request.env['ir.config_parameter'].sudo().get_param('google.region_localization')"/> | |||
| <t t-set="google_maps_libraries" t-value="request.env['ir.config_parameter'].sudo().get_param('google.maps_libraries')"/> | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4ee44c0. Thanks a lot for contributing to OCA. ❤️ |
@gityopie This is to bring your module for Google map drawing into the OCA geospatial repo
@yvaucher @OCA/geospatial-maintainers Comments regarding module name, etc are welcome. It may make more sense to name it base_google_map_drawing since this module doesn't do anything on its own and simply provides a mixin class to be used in other modules.