Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPD] Permissions Fixes with record rule #46

Merged
merged 1 commit into from
Jul 26, 2019
Merged

[UPD] Permissions Fixes with record rule #46

merged 1 commit into from
Jul 26, 2019

Conversation

AlhMaria
Copy link
Contributor

About the issue we talked about yesterday: "When you try to assing a ticket to another user, even being from the Helpdesk Manager team, a permission error occurs."

I just did this fix, please let me know if there's anything wrong.

DaniKL
DaniKL approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@DaniKL DaniKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 26, 2019
@pedrobaeza
Copy link
Member

Fast-tracking this as clear bugfix

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 11.0-ocabot-merge-pr-46-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 29ff1a0 into OCA:11.0 Jul 26, 2019
OCA-git-bot added a commit that referenced this pull request Jul 26, 2019
@OCA-git-bot
Merge PR #46 into 11.0
ac1a517 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac1a517. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

OCA-git-bot pushed a commit that referenced this pull request Aug 1, 2019
@aitorbouzas
[FIX+IMP] helpdesk: 4 things:
4fcada7 
* Fix tickets and naming conventions (#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (#49)
max3903 pushed a commit to ursais/helpdesk that referenced this pull request Oct 1, 2019
@aitorbouzas @max3903
[FIX+IMP] helpdesk: 4 things:
72f4191 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
emagdalenaC2i pushed a commit to Change2improve/helpdesk that referenced this pull request Oct 17, 2019
@aitorbouzas @emagdalenaC2i
[FIX+IMP] helpdesk: 4 things:
164cb76 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
nguyenductamlhp added a commit to nguyenductamlhp/helpdesk that referenced this pull request Dec 22, 2019
@nguyenductamlhp
Squashed 'addons/helpdesk/' changes from 2a795dd..1dae25d
0a785b0 
1dae25d Update translation files
ee1c1e5 Merge PR OCA#66 into 11.0
d77b180 helpdesk_mgmt 11.0.1.8.0
e41fcfe [UPD] Update helpdesk_mgmt.pot
dabd667 [FIX] fix email templates
9e7ced8 [FIX] Delete Odoo web in template
90273d0 [ADD] Email templates for closed tickets and changed state
3d2b78d Update translation files
426b58d [UPD] Update helpdesk_mgmt.pot
4247d15 [IMP] helpdesk_mgmt: Ticket creation from portal (OCA#75)
91bf86e Merge PR OCA#73 into 11.0
3b3d946 helpdesk_mgmt 11.0.1.7.0
7e953ce [FIX] Security fixes
ac5104f Merge PR OCA#48 into 11.0
828f3b5 helpdesk_mgmt 11.0.1.6.0
be95d0a Changes on settings tree views
a0a07c2 Merge PR OCA#56 into 11.0
f9aedcf helpdesk_mgmt 11.0.1.5.1
15c29d2 [IMP] helpdesk_mgmt: at creation last_stage_update use actual now instead of server start time
0683fcc Update translation files
c155c07 Merge PR OCA#57 into 11.0
e9e5f5a helpdesk_mgmt 11.0.1.5.0
97db434 [UPD] Update helpdesk_mgmt.pot
e327904 fix ticket assignment mail subject
35a6f19 Update translation files
de507ed Merge PR OCA#53 into 11.0
783c625 helpdesk_mgmt 11.0.1.4.1
1f96a0b [UPD] Update helpdesk_mgmt.pot
f7e5aba Fix assigned date on ticket creation
4998f0a Merge PR OCA#52 into 11.0
6101937 helpdesk_mgmt 11.0.1.4.0
be05198 Added default filter to tickets tree view
4f85eb3 [IMP] helpdesk_mgmt: Logo update (OCA#51)
f1e4a6a [UPD] README.rst
e791608 Merge PR OCA#43 into 11.0
da5fc45 helpdesk_mgmt 11.0.1.3.0
ee8b18b [IMP] helpdesk_mgmt : ticket close action was crashing, casting *_id to int in controller
0b70fcc [FIX] helpdesk_mgmt : fix call to ticket list rendering on portal + lint
ac1a517 Merge PR OCA#46 into 11.0
6e6abc9 helpdesk_mgmt 11.0.1.2.0
29ff1a0 [UPD] Permissions Fixes with record rule
7083b55 Translated using Weblate (Portuguese (Brazil))
b6ee3b5 Added translation using Weblate (Portuguese (Brazil))
b3da4cc [UPD] Update helpdesk_mgmt.pot
cf22fe1 Merge PR OCA#29 into 11.0
a77764b helpdesk_mgmt 11.0.1.1.0
e8c83c4 Multi company behaviour fix.

git-subtree-dir: addons/helpdesk
git-subtree-split: 1dae25d
cubells pushed a commit to cubells/helpdesk that referenced this pull request Apr 1, 2020
@aitorbouzas @cubells
[FIX+IMP] helpdesk: 4 things:
635833d 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
dalonsod pushed a commit to solvosci/helpdesk that referenced this pull request Nov 18, 2020
@aitorbouzas @dalonsod
[FIX+IMP] helpdesk: 4 things:
d5b517d 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
jacob88 pushed a commit to jacob88/helpdesk that referenced this pull request Nov 7, 2021
@aitorbouzas @jacob88
[FIX+IMP] helpdesk: 4 things:
19d4ccd 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
jacob88 pushed a commit to jacob88/helpdesk that referenced this pull request Dec 24, 2021
@aitorbouzas @jacob88
[FIX+IMP] helpdesk: 4 things:
02cae90 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
jacob88 pushed a commit to jacob88/helpdesk that referenced this pull request Dec 24, 2021
@aitorbouzas @jacob88
[FIX+IMP] helpdesk: 4 things:
62ecfaa 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
jacob88 pushed a commit to jacob88/helpdesk that referenced this pull request Jan 16, 2022
@aitorbouzas @jacob88
[FIX+IMP] helpdesk: 4 things:
c25263d 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
zuher83 pushed a commit to zuher83/helpdesk that referenced this pull request Feb 27, 2023
@aitorbouzas @zuher83
[FIX+IMP] helpdesk: 4 things:
90bdca9 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
chandni-serpentcs pushed a commit to chandni-serpentcs/helpdesk that referenced this pull request Jan 3, 2024
@aitorbouzas @chandni-serpentcs
[FIX+IMP] helpdesk: 4 things:
f7b6353 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
reichie020212 pushed a commit to OpenSPP/helpdesk that referenced this pull request Feb 13, 2024
@aitorbouzas @reichie020212
[FIX+IMP] helpdesk: 4 things:
0868167 
* Fix tickets and naming conventions (OCA#46)
* Save sequence number in in 'number' field instead of in helpdesk_sequence.
* Also fixed tests and added a small test to check if a number is added in a ticket when we create one.
* Add many views and fix others (OCA#49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@DaniKL DaniKL DaniKL approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlhMaria @pedrobaeza @OCA-git-bot @DaniKL