Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hr_holidays_auto_approve: overwrites tracking_disable=True #498

Closed
gurneyalex opened this issue Oct 30, 2018 · 0 comments
Closed

hr_holidays_auto_approve: overwrites tracking_disable=True #498

gurneyalex opened this issue Oct 30, 2018 · 0 comments

Comments

@gurneyalex
Copy link
Member

If I create a holiday with tracking_disable = True and a holiday type with auto approve false, I expect that no emails are going to be sent. However this line:

https://github.com/OCA/hr/blob/10.0/hr_holidays_leave_auto_approve/models/hr_holidays.py#L21

bypasses the value I put in the context.
gurneyalex added a commit to gurneyalex/hr that referenced this issue Oct 30, 2018
@gurneyalex
[FIX] hr_holidays_leave_auto_approve tracking handling
019dafa 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
@gurneyalex gurneyalex mentioned this issue Oct 30, 2018
Merged
gurneyalex added a commit to gurneyalex/hr that referenced this issue Oct 30, 2018
@gurneyalex
[FIX] hr_holidays_leave_auto_approve tracking handling
9c4f105 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
@gurneyalex gurneyalex mentioned this issue Oct 30, 2018
Merged
gurneyalex added a commit to camptocamp/hr that referenced this issue Oct 30, 2018
@gurneyalex
hr_holidays_leave_auto_approve tracking handling
e1d2667 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
gurneyalex added a commit to gurneyalex/hr that referenced this issue Oct 30, 2018
@gurneyalex
[FIX] hr_holidays_leave_auto_approve tracking handling
add78d1 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
gurneyalex added a commit to gurneyalex/hr that referenced this issue Oct 30, 2018
@gurneyalex
[FIX] hr_holidays_leave_auto_approve tracking handling
4d1cb94 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
gurneyalex added a commit to camptocamp/hr that referenced this issue Oct 30, 2018
@gurneyalex
hr_holidays_leave_auto_approve tracking handling
f1b1494 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
gurneyalex added a commit to camptocamp/hr that referenced this issue Oct 31, 2018
@gurneyalex
hr_holidays_leave_auto_approve tracking handling
eb21206 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
ovnicraft pushed a commit to prisehub/hr that referenced this issue Nov 14, 2018
@gurneyalex @ovnicraft
[FIX] hr_holidays_leave_auto_approve tracking handling
a1c8908 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
hhgabelgaard pushed a commit to steingabelgaard/hr that referenced this issue Dec 30, 2018
@gurneyalex @hhgabelgaard
[FIX] hr_holidays_leave_auto_approve tracking handling
34e3ea8 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this issue Mar 12, 2019
@gurneyalex
[FIX] hr_holidays_leave_auto_approve tracking handling
dc61a15 
If tracking is disabled through the context, the module should not
reenable it.

closes OCA#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gurneyalex