[MIG] hr_employee_firstname: Migration to 15.0 #1038

luistorresm · 2021-10-18T16:53:08Z

No description provided.

luistorresm · 2021-10-18T18:46:10Z

Hello @sbidoul

Do you know which is the problem with the pre-commit? I do not see the relation with my MR

Regards

sbidoul · 2021-10-18T19:27:34Z

Yes this was discussed on the mailing list. The fix is on its way. Please rebase when it is applied.

luistorresm · 2021-10-18T21:06:26Z

Yes this was discussed on the mailing list. The fix is on its way. Please rebase when it is applied.

Sorry @sbidoul

The URL in your last comment is incorrect, could you update it, please?

Regards

* remove ensure one * Add decorator * Update name on write and update related partner firstname lastname * Modify README file * Change version format * Consistency with partner_firstname module * Check if the partner isn't already in the list * Remove check on partner_firstname installation

… value not the key of dict (OCA#215) * Update split names at module install to get the value not the key of the dict. * Add test for checking right values in firstname, lastname after install

This issue was flagged by travis in the following build https://travis-ci.org/OCA/hr/jobs/364219109

Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/fa/

Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/de/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/es/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/pt_BR/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/hr/

Currently translated at 100.0% (11 of 11 strings) Translation: hr-14.0/hr-14.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_firstname/de/

hr_employee_firstname/init_hook.py

luistorresm · 2021-10-20T22:19:10Z

Hello @gurneyalex

Could you help me with the runbot from this repo on v15?

This is red, even without my PR, and I cannot see the log to see which is the error.

Regards

luistorresm · 2021-11-03T20:07:31Z

Hello @gurneyalex

Could you help me with the runbot from this repo on v15?

This is red, even without my PR, and I cannot see the log to see which is the error.

Regards

Hello @gurneyalex

Do you have news about runbot v15?

Regards

moylop260 · 2021-11-04T15:36:36Z

/ocabot merge nobump

OCA-git-bot · 2021-11-04T15:36:53Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1038-by-moylop260-bump-nobump, awaiting test results.

Signed-off-by moylop260

OCA-git-bot · 2021-11-04T15:38:22Z

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1038-by-moylop260-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul · 2021-11-04T15:47:44Z

There is something strange here. The merge fails because the setup.py is not present for the new module. When I run pre-commit run -a locally it's red because it wants to add setup.py (which is correct). I don't understand why pre-commit is green on the PR.

luistorresm · 2021-11-04T16:56:23Z

There is something strange here. The merge fails because the setup.py is not present for the new module. When I run pre-commit run -a locally it's red because it wants to add setup.py (which is correct). I don't understand why pre-commit is green on the PR.

Thanks @sbidoul

Do you know how I could add the module to the setup?

Regards

sbidoul · 2021-11-04T17:06:27Z

@luistorresm can you try running pre-commit run -a locally ? It should generate a few files in the setup directory that you can simply commit into git.

I'm really confused by the fact that pre-commit did not pick this up on the CI.

luistorresm · 2021-11-04T18:23:08Z

Thanks @sbidoul

@moylop260

Now the setup was loaded, could you retry the merge, please?

Regards

moylop260 · 2021-11-04T18:32:20Z

/ocabot merge nobump

OCA-git-bot · 2021-11-04T18:32:32Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1038-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2021-11-04T18:36:42Z

Congratulations, your PR was merged at 1fa1201. Thanks a lot for contributing to OCA. ❤️

luistorresm mentioned this pull request Oct 18, 2021

Migration to version 15.0 #1036

Closed

27 tasks

luistorresm force-pushed the 15.0-hr_employee_firstname-luist branch 2 times, most recently from 9ba86a4 to 59268c8 Compare October 18, 2021 18:36

feketemihai and others added 24 commits October 19, 2021 15:01

[ADD] hr_employee_firstname

8851ddf

Remove field name related, change init script, add unittests

97d1744

OCA Transbot updated translations from Transifex

5baf491

[IMP][hr_employee_firstname] Avoid to update partners without reason

803b1c9

[FIX] Update tests in hr_employee_firstname - failing travis

88b7fcd

[REF] hr_employee_firstname: Split names at module install to get the…

7e22a81

… value not the key of dict (OCA#215) * Update split names at module install to get the value not the key of the dict. * Add test for checking right values in firstname, lastname after install

[MIG] hr_employee_firstname: Migrated to 10.0 (OCA#276)

a18bcea

[MIG] hr_employee_firstname: Migration to version 11.0

795c553

[FIX] employee_firstname: test (OCA#427)

8d2ffc3

[11.0][FIX] Fix dangerous use of 'replace' from hr.employee view.

9775d88

This issue was flagged by travis in the following build https://travis-ci.org/OCA/hr/jobs/364219109

OCA Transbot updated translations from Transifex

048e6fc

Translated using Weblate (Persian)

7dc8acd

Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/fa/

Translated using Weblate (German)

6043c16

Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/de/

[12.0][MIG] hr_employee_firstname

4e43caf

[FIX/IMP] Make required attributes dynamic

e0dbf84

Translated using Weblate (German)

4b0c970

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/

Translated using Weblate (Spanish)

b77be0c

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/es/

Translated using Weblate (Portuguese (Brazil))

ffd97b0

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/pt_BR/

Translated using Weblate (German)

0f6a74c

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/

Translated using Weblate (Croatian)

0bbda16

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/hr/

[13.0][MIG] hr_employee_firstname

63e2f37

pre-commit

6e03a42

pre-commit update

21c0e24

OCA-git-bot and others added 2 commits October 19, 2021 15:22

hr_employee_firstname 14.0.3.0.0

119a657

Translated using Weblate (German)

178527d

Currently translated at 100.0% (11 of 11 strings) Translation: hr-14.0/hr-14.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_firstname/de/

luistorresm force-pushed the 15.0-hr_employee_firstname-luist branch from 33ad8f7 to d3fdb95 Compare October 19, 2021 15:22

hugho-ad approved these changes Oct 19, 2021

View reviewed changes

sbidoul reviewed Oct 19, 2021

View reviewed changes

hr_employee_firstname/init_hook.py Outdated Show resolved Hide resolved

luistorresm force-pushed the 15.0-hr_employee_firstname-luist branch from d3fdb95 to 3f5cf7e Compare October 19, 2021 18:05

luiseevaquer approved these changes Oct 19, 2021

View reviewed changes

OCA-git-bot added the approved label Oct 19, 2021

OCA-git-bot added the bot is merging ⏳ label Nov 4, 2021

OCA-git-bot added a commit that referenced this pull request Nov 4, 2021

Merge PR #1038 into 15.0

51323da

Signed-off-by moylop260

OCA-git-bot removed the bot is merging ⏳ label Nov 4, 2021

[MIG] hr_employee_firstname: Migration to 15.0

009a69d

luistorresm force-pushed the 15.0-hr_employee_firstname-luist branch from 3f5cf7e to 009a69d Compare November 4, 2021 18:15

OCA-git-bot added the bot is merging ⏳ label Nov 4, 2021

OCA-git-bot merged commit 6c587fa into OCA:15.0 Nov 4, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 4, 2021

luistorresm deleted the 15.0-hr_employee_firstname-luist branch November 4, 2021 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] hr_employee_firstname: Migration to 15.0 #1038

[MIG] hr_employee_firstname: Migration to 15.0 #1038

luistorresm commented Oct 18, 2021

luistorresm commented Oct 18, 2021

sbidoul commented Oct 18, 2021

luistorresm commented Oct 18, 2021

luistorresm commented Oct 20, 2021

luistorresm commented Nov 3, 2021

moylop260 commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

sbidoul commented Nov 4, 2021

luistorresm commented Nov 4, 2021

sbidoul commented Nov 4, 2021

luistorresm commented Nov 4, 2021

moylop260 commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

[MIG] hr_employee_firstname: Migration to 15.0 #1038

[MIG] hr_employee_firstname: Migration to 15.0 #1038

Conversation

luistorresm commented Oct 18, 2021

luistorresm commented Oct 18, 2021

sbidoul commented Oct 18, 2021

luistorresm commented Oct 18, 2021

luistorresm commented Oct 20, 2021

luistorresm commented Nov 3, 2021

moylop260 commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

sbidoul commented Nov 4, 2021

luistorresm commented Nov 4, 2021

sbidoul commented Nov 4, 2021

luistorresm commented Nov 4, 2021

moylop260 commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021

OCA-git-bot commented Nov 4, 2021