[8.0] Port HR Department Sequence #123

adrienpeiffer · 2015-07-28T15:21:36Z

Supersedes #119

ghost · 2015-07-28T15:26:59Z

👍 if travis is green

mmalorni · 2015-07-28T17:44:06Z

Works but the sequence doesn't take into consideration the hierarchy. In fact, every time you play with the sequence in the department form tree view, it screws the department tree view because it adds duplicate sequence numbers. 👍
For exemple: You have sales and marketing, you position sales after marketing (before that, the sequence is 0 for all), you go in the sales department and add a Direct Sales and eCommerce Sales, you move eCommerce before Direct Sales, when you go back to the Department View, the sequence is

1 - Marketing
1 - Elearning Sales
2 - Direct Sales
2 - Sales

Instead of

1 - Marketing
2 - Sales
3 - Elearning Sales
4 - Direct Sales

dreispt · 2015-07-28T22:37:56Z

Please, it's best to force-push the branch of the initial PR instead of creating a new one.
This disconsiders the history and effort put in the review of the original PR.

adrienpeiffer · 2015-07-29T07:29:18Z

@dreispt It is what I did. But the PR was closed when I did that

dreispt · 2015-07-29T10:21:46Z

@adrienpeiffer Hmm, you're right. Now that you mention that, I got a similar problem after force pushing a PR.
Is that a new GitHub behaviour for PRs?

adrienpeiffer · 2015-07-31T08:16:14Z

I don't really know. I think that what happens when the PR is closed ...

dreispt · 2015-07-31T09:01:48Z

hr_department_sequence/models/hr_department.py

+            if departments.ids:
+                return departments.name_get()
+        return super(HrDepartment, self)\
+            .name_search(name=name, args=args, operator=operator, limit=limit)


I think this name_get and name_search should be optional or, even better, configurable.
But that can be a future improvement.

dreispt · 2015-07-31T09:27:52Z

👍

yvaucher · 2015-08-13T16:30:31Z

hr_department_sequence/README.rst

+======================
+
+This module was written to allow you to order department by Parent-Child Relationship and by Sequence Number.
+It also adds some fields on the department like code and active.


I don't really like the "adds some fields ... like" I prefer to know what I'm installing.

I understand that all fields but those two are used for the parent-child relation. So you could simply remove that "like" and extend a bit with a "It also extends department by adding the two extra fields code and active to ease management with many departments"

yvaucher · 2015-08-13T16:34:15Z

I added few remarks

adrienpeiffer · 2015-08-24T10:08:25Z

Thanks @yvaucher. It's done !

yvaucher · 2015-08-24T10:18:07Z

Thanks for the fixes 👍

- Remove ondelete='cascade' because it can have serious consequences

- Change _order to match with sequence modification - Add children One2many on department to simplify sequence management - Add sequence handle - Hide sequence field on department form view

…alidation error whith duplicate

…r_department

…nstraint declaration

…code's field

feketemihai · 2015-11-12T07:06:00Z

👍 I never knew untill now the widget=handle...Great.

But i think we should change the pr to the department repo. It's more appropriate.

lmignon · 2015-11-12T07:17:42Z

👍 Travis errors seem unrelated to your changes

[8.0] Port HR Department Sequence

[BSSFL-155] Bank

BSO HR Validation

max3903 mentioned this pull request Jul 28, 2015

Migration to version 8 #86

Closed

58 tasks

dreispt reviewed Jul 31, 2015
View reviewed changes

max3903 added this to the 8.0 milestone Jul 31, 2015

yvaucher reviewed Aug 13, 2015
View reviewed changes

yvaucher added the needs fixing label Aug 13, 2015

yvaucher added needs review and removed needs fixing labels Aug 24, 2015

adrienpeiffer added 12 commits November 9, 2015 17:18

[CHG][hr_department_sequence] Add readme file

0ced80f

[MIG][hr_department_sequence] Use new API

e0e59a5

- Remove ondelete='cascade' because it can have serious consequences

[IMP][hr_department_sequence] Improve sequence management :

871de74

- Change _order to match with sequence modification - Add children One2many on department to simplify sequence management - Add sequence handle - Hide sequence field on department form view

[IMP][hr_department_sequence] Add copy overloading to avoid to have v…

40f3d0b

…alidation error whith duplicate

[ADD][hr_department_sequence] Add active field

2d8a39c

[ADD][hr_department_sequence] Add models and views folder

5ccb60d

[ADD][hr_department_sequence] Add ondelete restrict on parent_id on h…

cbcb952

…r_department

[IMP][hr_department_sequence] Move warning message directly in the co…

8d48b77

…nstraint declaration

[ADD][hr_department_sequence] Add code filter on department search view

e6f2e8a

[IMP][hr_department_sequence] Improve copy and name_search method

96f86ac

[DEL][hr_department_sequence] Remove unnecessary string attribute on …

16792c7

…code's field

[IMP] Improve description in readme file

251fa66

adrienpeiffer force-pushed the 8.0-port-hr-department-sequence-ape branch from fce7f88 to 251fa66 Compare November 9, 2015 16:19

dreispt added a commit that referenced this pull request Nov 12, 2015

Merge pull request #123 from acsone/8.0-port-hr-department-sequence-ape

ed3140f

[8.0] Port HR Department Sequence

dreispt merged commit ed3140f into OCA:8.0 Nov 12, 2015

dreispt removed the needs review label Nov 12, 2015

adrienpeiffer deleted the 8.0-port-hr-department-sequence-ape branch December 11, 2015 14:48

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

Merge pull request OCA#123 from LoicSenseFly/BSSFL-155_Bank

1ba6ed9

[BSSFL-155] Bank

Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019

Merge pull request OCA#123 from gcoudu/bso_hr_validation

c8f1a70

BSO HR Validation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.0] Port HR Department Sequence #123

[8.0] Port HR Department Sequence #123

adrienpeiffer commented Jul 28, 2015

ghost commented Jul 28, 2015

mmalorni commented Jul 28, 2015

dreispt commented Jul 28, 2015

adrienpeiffer commented Jul 29, 2015

dreispt commented Jul 29, 2015

adrienpeiffer commented Jul 31, 2015

dreispt Jul 31, 2015

dreispt commented Jul 31, 2015

yvaucher Aug 13, 2015

yvaucher commented Aug 13, 2015

adrienpeiffer commented Aug 24, 2015

yvaucher commented Aug 24, 2015

feketemihai commented Nov 12, 2015

lmignon commented Nov 12, 2015

[8.0] Port HR Department Sequence #123

[8.0] Port HR Department Sequence #123

Conversation

adrienpeiffer commented Jul 28, 2015

ghost commented Jul 28, 2015

mmalorni commented Jul 28, 2015

dreispt commented Jul 28, 2015

adrienpeiffer commented Jul 29, 2015

dreispt commented Jul 29, 2015

adrienpeiffer commented Jul 31, 2015

dreispt Jul 31, 2015

Choose a reason for hiding this comment

dreispt commented Jul 31, 2015

yvaucher Aug 13, 2015

Choose a reason for hiding this comment

yvaucher commented Aug 13, 2015

adrienpeiffer commented Aug 24, 2015

yvaucher commented Aug 24, 2015

feketemihai commented Nov 12, 2015

lmignon commented Nov 12, 2015