[8.0] Port employee firstname module #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's already a PR for this: #99, but it seems stalled. Please check comments on that PR and see what it the best one for continuing the work. |
|
in #99 there are tests that we surely want. @adrienpeiffer as #99 is stalled could you have a look at this other PR and superseeds it taking what was done in it? |
…partner firstname lastname
adrienpeiffer
force-pushed
the
8.0-port-employee-firstname-ape
branch
from
b5d14fa
to
5bac94f
Compare
|
Hi ! |
|
Thanks @adrienpeiffer I closed #99 |
| @@ -21,34 +21,23 @@ | |||
| ############################################################################## | |||
|
|
|||
| { | |||
| 'name': 'Employee First Name, Last Name', | |||
| 'name': 'HR Employee First Name, Last Name', | |||
| 'version': '0.1', | |||
There was a problem hiding this comment.
Can you use full version number ? 8.0.0.1
|
👍 |
1 similar comment
|
👍 |
|
@yvaucher. It's done. Thanks ! |
yvaucher
added a commit
that referenced
this pull request
Aug 13, 2015
[8.0] Port employee firstname module
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-240] Run create data ranges song
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
Remove unused PO file to reduce docker image size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.