Port hr_employee_benefit to 8.0 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | ||
| `here <https://github.com/OCA/{project_repo}/issues/new?body=module:%20{module_name}%0Aversion:%20{version}%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
There was a problem hiding this comment.
You let the {project_repo} {module_name}, ...
|
Code review: 👍 |
ghost
force-pushed
the
8.0-hr_employee_benefit
branch
from
0fadb96
to
2ae9c0a
Compare
| return res | ||
|
|
||
| @api.multi | ||
| def _filter_benefits(self, payslip, **kwargs): |
There was a problem hiding this comment.
@dufresnedavid Why do we need **kwargs here?
There was a problem hiding this comment.
@dufresnedavid If we are returning a type other than self maybe it would be the case to declare the decaorator @api.returns().
There was a problem hiding this comment.
@joaoalf we need kwargs to enable other modules to inherit the function easily.
| from .hr_employee_benefit_rate import get_amount_types | ||
|
|
||
|
|
||
| class HrEmployeeBenefit(models.Model): |
There was a problem hiding this comment.
@dufresnedavid Just a sugestion:
class HrEmployeeBenefit(models.Model):
"""Employee Benefit"""
_name = 'hr.employee.benefit'
_description = _(__doc__)
|
👍 |
ghost
force-pushed
the
8.0-hr_employee_benefit
branch
from
1d60067
to
ac778a3
Compare
ghost
force-pushed
the
8.0-hr_employee_benefit
branch
from
ac778a3
to
589ade7
Compare
|
👍 |
max3903
pushed a commit
that referenced
this pull request
Oct 2, 2015
[REF] hr_employee_benefit to 8.0
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-207] Add product responsibles and product followers
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.