8.0 hr payroll analysis #150
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
| """ | ||
| for payslip in self: | ||
| for line in payslip.analysis_line_ids: | ||
| line.unlink() |
There was a problem hiding this comment.
you may call directly self.mapped('analytic_line_ids').unlink() with no loop at all.
|
@tarzan0820 thank you very much for porting this module |
|
@dufresnedavid thanks for the review... I have effected the changes... please review when you can Also I noticed that most of the py files had licensing information at the top, was it right of me to remove them? |
|
@tarzan0820 No, don't remove the licences and let the copy right of savoir-faire linux. You may add your name to the copyrights because you contributed. This is the right way to do things as described by the gnu organisation: http://www.gnu.org/licenses/gpl-howto.en.html |
|
I apologize for this; during my first attempt at porting a module one of the reviewers had me remove the licensing info... I will add them back |
| @api.multi | ||
| def payroll_analysis_open_window(self): | ||
| """ | ||
| This method returns an action that displays profitability lines |
There was a problem hiding this comment.
My mistake when writing this line. I copied this from another module. profitability should be analysis
|
👍 code + functional Thank you very much! |
|
The module has good intention, and a payroll analysis is needed, but is it worth it to write other code instead of adding a graph view on the hr.payslip.line and declare some grouping and filter, because you have all the fields that you declare in the code. Opinions? |
|
@feketemihai I agree with you, it is not worth creating a seperate model. Could just group payslip lines. |
|
hi. |
[BSSFL-169] Add module rma webhook
…_invoice_date_to_cron BSIBSO-1033 Set subscription invoice date to cron run date
No description provided.