Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 hr employee exemption #165

Closed
wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2015

No description provided.


{
'name': 'Employee Exemption',
'version': '1.0',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use correct versioning convention

@ghost ghost force-pushed the 8.0-hr_employee_exemption branch from f3f6fbd to 635457f Compare October 18, 2015 11:20
@ghost ghost force-pushed the 8.0-hr_employee_exemption branch from 635457f to 142a00e Compare October 18, 2015 11:29
@ghost
Copy link
Author

ghost commented Oct 19, 2015

Anyone has an idea why travis can not install the module partner_firstname ?

@feketemihai
Copy link
Member

@dufresnedavid I think the logic is quite different, you can have one salary rule and many exemtions based on the employee, so i suggest to change the relation between salary.rule and hr.income.tax.exemption.

@feketemihai feketemihai added this to the 8.0 milestone Nov 12, 2015
@ghost
Copy link
Author

ghost commented Nov 12, 2015

@feketemihai I don't understand the use case behind your question.

Example, I have one rule that computes the Canada Income Tax to withdraw for the period. The employee is ether exempted or not from the Canada Income Tax. So I create one exemption which might be named "Canada Federal Income Tax" and then I assign it to the employee.

@feketemihai
Copy link
Member

Agree with you but instead of having one2many to salary rule i said to have a many2one so you could add different exemption per one salary rule...dependant of some condition of the employee...

Sent from my Samsung device

-------- Original message --------
From: David Dufresne notifications@github.com
Date: 12/11/2015 16:14 (GMT+02:00)
To: OCA/hr hr@noreply.github.com
Cc: Mihai FEKETE Mihai.FEKETE@forbiom.eu
Subject: Re: [hr] 8.0 hr employee exemption (#165)

@feketemihaihttps://github.com/feketemihai I don't understand the use case behind your question.

Example, I have one rule that computes the Canada Income Tax to withdraw for the period. The employee is ether exempted or not from the Canada Income Tax. So I create one exemption which might be named "Canada Federal Income Tax" and then I assign it to the employee.

Reply to this email directly or view it on GitHubhttps://github.com//pull/165#issuecomment-156112533.

@ghost
Copy link
Author

ghost commented Nov 12, 2015

@feketemihai I think that this would be too much complicate for the person who configures the system. Exemptions are rare cases. I prefer let the hr manager attribute an exemption manually to an employee than relying on a script to figure out if the employee is exempted, based on some conditions.

@feketemihai
Copy link
Member

Ok then...
👍

@feketemihai
Copy link
Member

Could you also add issue paragraph in readme file and Try me on runbot at the end of the Usage paragraph.
Thanks..

@max3903 max3903 mentioned this pull request Nov 13, 2015
58 tasks
@ghost ghost closed this May 10, 2016
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
[FIX] preserve price and description in PO
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants