[hr_emergency_contact] Migrate to 8.0 + refactoring

[andhit-r]

See readme

[feketemihai]

Hi @andhit-r , thanks for your work, can you check the copyright section of the files, it's quite messy and you should leave © 2011 Michael Telahun Makonnen, since he is the one that proposed the module to OCA, even if you refactor a little bit( rename of file), i think we should keep that, plus an author line in the copyright doesn't make sense...i think we should just stick to the author tab in the manifest file.

Plus can you remove the unused files from the static folder.

[andhit-r]

@feketemihai thanks for your review. Would you show me which copyright? I am sure i have cleaned copyright file into latest OCA format and retain @miketelahun copyright. Maybe i miss something

• https://github.com/andhit-r/hr/blob/56737aeab31e1479d0e95b126e0bd0e75dcaea83/hr_emergency_contact/__init__.py
• https://github.com/andhit-r/hr/blob/56737aeab31e1479d0e95b126e0bd0e75dcaea83/hr_emergency_contact/__openerp__.py
• https://github.com/andhit-r/hr/blob/56737aeab31e1479d0e95b126e0bd0e75dcaea83/hr_emergency_contact/models/hr_employee.py

Only one file that does not contain @miketelahun copyright:

• https://github.com/andhit-r/hr/blob/56737aeab31e1479d0e95b126e0bd0e75dcaea83/hr_emergency_contact/models/__init__.py

That is because that file does not exist on previous version. But if @miketelahun copyright should be stated on that file i will add it. No problem.

[andhit-r]

@feketemihai i pushed PR contain revision based on your comments. You you kindly review it again. Many thanks.

[feketemihai]

Can you remove the _name line...by inheriting you don't need it

[andhit-r]

@feketemihai done.

[feketemihai]

👍

[andhit-r]

@feketemihai thanks for all your reviews.

[azmimr67]

Well tested 👍

[andhit-r]

@feketemihai would you add needs review label to this PR. Thanks

[andhit-r]

@OCA/human-resources-maintainers would you kindly review this PR. Thanks in advance.

[mikevhe18]

👍

[andhit-r]

@OCA/human-resources-maintainers i think this PR is ready to be merged (3 reviews)

[pedrobaeza]

Don't include the SVG on the unaltered icon

[coveralls]

Coverage decreased (-0.5%) to 86.199% when pulling 45be4e5 on andhit-r:8.0-hr_emergency_contact into 90c4d1f on OCA:8.0.

[andhit-r]

@pedrobaeza thank you for your review. I pushed revision according your latest input.

[pedrobaeza]

👍 Merging

[andhit-r]

Thanks @pedrobaeza. Thanks all reviewers.