Update Hr holidays compute days #210

feketemihai · 2016-03-09T09:27:59Z

This is a update from #175 . I will close that one.

feketemihai · 2016-03-09T10:43:52Z

Depends on #209 .

elicoidal · 2016-03-09T10:49:04Z

hr_holidays_compute_days/README.rst

+Configuration
+=============
+
+Go to your holiday status and specify what leaves should not include rest days


Go to your holiday status and specify for their computation which leaves should not include rest days
or holidays.

elicoidal · 2016-03-09T10:53:24Z

thanks for the contribution!

feketemihai · 2016-03-10T04:38:27Z

@elicoidal I't not me that created the module, it's idt labs or salton massaly, the ideea is that i try to finish most of the PR that remained untouch for more months, this was #175 .

elicoidal · 2016-03-10T05:30:47Z

@feketemihai I understand and that is an excellent initiative. Still can you make sure the authorship is clean (put the contributor in the README and only input the company in the author tag.
Depending on your input, you might want to add your name somewhere as well

coveralls · 2016-03-25T05:45:01Z

Coverage decreased (-5.2%) to 81.465% when pulling a383215 on feketemihai:hr_holidays_compute_days into 90c4d1f on OCA:8.0.

coveralls · 2016-03-31T04:19:08Z

Coverage decreased (-5.2%) to 81.465% when pulling 33f8178 on feketemihai:hr_holidays_compute_days into 90c4d1f on OCA:8.0.

coveralls · 2016-04-06T05:11:04Z

Coverage decreased (-0.4%) to 86.091% when pulling 790f6ff on feketemihai:hr_holidays_compute_days into 8b43a91 on OCA:8.0.

coveralls · 2016-04-06T05:25:11Z

Coverage decreased (-0.4%) to 86.091% when pulling 2a21a40 on feketemihai:hr_holidays_compute_days into 8b43a91 on OCA:8.0.

feketemihai · 2016-04-06T07:43:24Z

@OCA/human-resources-maintainers Can you review this please, to have the correct number of days in leaves...

…ute_days

…ract, and hr manager to have the same rigths as defined in hr_contract.

coveralls · 2016-05-10T11:08:07Z

Coverage decreased (-0.4%) to 87.308% when pulling 7175407 on feketemihai:hr_holidays_compute_days into e13586a on OCA:8.0.

moylop260 · 2016-05-10T14:05:28Z

hr_holidays_compute_days/models/hr_holidays.py

+            'employee_id',
+            False)
+        if not self._check_date_helper(employee_id, date_from):
+            raise ValidationError('You cannot schedule the start date on '


Add translation method: _('msg')

moylop260 · 2016-05-10T14:13:17Z

Could you add a test calling to onchange_employee and onchange_date methods?

coveralls · 2016-05-11T04:23:40Z

Coverage increased (+0.2%) to 87.931% when pulling 97e2239 on feketemihai:hr_holidays_compute_days into e13586a on OCA:8.0.

coveralls · 2016-05-11T05:01:42Z

Coverage increased (+0.2%) to 87.931% when pulling 82b6882 on feketemihai:hr_holidays_compute_days into e13586a on OCA:8.0.

moylop260 · 2016-05-11T06:38:29Z

Thanks for changes
👍

feketemihai · 2016-05-11T06:39:35Z

@moylop260 I have to thank you for taking time reviewing...Thanks again.

jgrandguillaume · 2016-05-11T08:59:13Z

Hi,

Thanks for the contribution ! Functional tests are fine, thanks for the contrib. 👍

Regards,

Joël

leemannd · 2016-05-18T07:30:37Z

Thanks for the work. 👍

moylop260 · 2016-05-18T13:20:18Z

Thanks for contribution

* Squash commits into a single one. * Update tests with old onchange methods. * Fix variable name in tests.. * Update tests. * Update flake8. * Update security rules so that employee can read his schedule and contract, and hr manager to have the same rigths as defined in hr_contract. * Improve onchange employee, add tests for onchange. * Fix flake, whitespaces.

[BSSFL-322] Wave

* Squash commits into a single one. * Update tests with old onchange methods. * Fix variable name in tests.. * Update tests. * Update flake8. * Update security rules so that employee can read his schedule and contract, and hr manager to have the same rigths as defined in hr_contract. * Improve onchange employee, add tests for onchange. * Fix flake, whitespaces.

…fine-multicurrency-flow BSIBSO-1073 Fix multicurrency flow in `crm.lead`

* Squash commits into a single one. * Update tests with old onchange methods. * Fix variable name in tests.. * Update tests. * Update flake8. * Update security rules so that employee can read his schedule and contract, and hr manager to have the same rigths as defined in hr_contract. * Improve onchange employee, add tests for onchange. * Fix flake, whitespaces.

feketemihai added this to the 8.0 milestone Mar 9, 2016

elicoidal reviewed Mar 9, 2016
View reviewed changes

elicoidal added needs review needs fixing labels Mar 9, 2016

feketemihai mentioned this pull request Mar 23, 2016

[ADD] hr_holidays_working_time module acsone/acsone-addons#95

Closed

2 tasks

feketemihai force-pushed the hr_holidays_compute_days branch 3 times, most recently from 38a8848 to 399a611 Compare April 5, 2016 09:52

Squash commits into a single one.

399a611

feketemihai removed the needs fixing label Apr 5, 2016

feketemihai added 3 commits April 5, 2016 20:24

Update tests with old onchange methods.

ba87470

Fix variable name in tests..

6374cce

Update tests.

790f6ff

Update flake8.

2a21a40

max3903 mentioned this pull request Apr 8, 2016

Migration to version 8 #86

Closed

58 tasks

feketemihai added 2 commits May 10, 2016 03:30

Merge branch '8.0' of https://github.com/OCA/hr into hr_holidays_comp…

56382fb

…ute_days

Update security rules so that employee can read his schedule and cont…

7175407

…ract, and hr manager to have the same rigths as defined in hr_contract.

moylop260 reviewed May 10, 2016
View reviewed changes

Improve onchange employee, add tests for onchange.

97e2239

Fix flake, whitespaces.

82b6882

moylop260 merged commit 4f745b6 into OCA:8.0 May 18, 2016

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

Merge pull request OCA#210 from LoicSenseFly/BSSFL-322_Wave

b4ecc94

[BSSFL-322] Wave

Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019

Merge pull request OCA#210 from arkostyuk/bsibso-1073/fix/crm-lead-re…

11cdc88

…fine-multicurrency-flow BSIBSO-1073 Fix multicurrency flow in `crm.lead`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Hr holidays compute days #210

Update Hr holidays compute days #210

feketemihai commented Mar 9, 2016

feketemihai commented Mar 9, 2016

elicoidal Mar 9, 2016

elicoidal commented Mar 9, 2016

feketemihai commented Mar 10, 2016

elicoidal commented Mar 10, 2016

coveralls commented Mar 25, 2016

coveralls commented Mar 31, 2016

coveralls commented Apr 6, 2016

coveralls commented Apr 6, 2016

feketemihai commented Apr 6, 2016

coveralls commented May 10, 2016 •

edited

Loading

moylop260 May 10, 2016

moylop260 commented May 10, 2016

coveralls commented May 11, 2016 •

edited

Loading

coveralls commented May 11, 2016 •

edited

Loading

moylop260 commented May 11, 2016

feketemihai commented May 11, 2016

jgrandguillaume commented May 11, 2016

leemannd commented May 18, 2016

moylop260 commented May 18, 2016

Update Hr holidays compute days #210

Update Hr holidays compute days #210

Conversation

feketemihai commented Mar 9, 2016

feketemihai commented Mar 9, 2016

elicoidal Mar 9, 2016

Choose a reason for hiding this comment

elicoidal commented Mar 9, 2016

feketemihai commented Mar 10, 2016

elicoidal commented Mar 10, 2016

coveralls commented Mar 25, 2016

coveralls commented Mar 31, 2016

coveralls commented Apr 6, 2016

coveralls commented Apr 6, 2016

feketemihai commented Apr 6, 2016

coveralls commented May 10, 2016 • edited Loading

moylop260 May 10, 2016

Choose a reason for hiding this comment

moylop260 commented May 10, 2016

coveralls commented May 11, 2016 • edited Loading

coveralls commented May 11, 2016 • edited Loading

moylop260 commented May 11, 2016

feketemihai commented May 11, 2016

jgrandguillaume commented May 11, 2016

leemannd commented May 18, 2016

moylop260 commented May 18, 2016

coveralls commented May 10, 2016 •

edited

Loading

coveralls commented May 11, 2016 •

edited

Loading

coveralls commented May 11, 2016 •

edited

Loading