Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] hr_employment_termination #217

Closed

Conversation

saltonmassally
Copy link

@andhit-r another dependencies of hr_infraction

Code is extract from hr_employee_state; reason been I needed the termination workflow but not the over functionality in that module

In a case like this how is authorship and copyright attribution handled?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 85.614% when pulling 00594aa on tarzan0820:8.0-hr_employment_termiantion into bfa8439 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 85.614% when pulling 0c3bb40 on tarzan0820:8.0-hr_employment_termiantion into bfa8439 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 85.526% when pulling 4c72d07 on tarzan0820:8.0-hr_employment_termiantion into bfa8439 on OCA:8.0.

@feketemihai
Copy link
Member

@tarzan0820 The copyright should belong to the author, it's just like changing a module name, the code is the same but moved to a new module...so first copyright should belong to Michael Telahun Makonnen, you can add yourself(company) as of 2016...

I agree with adding this module to oca, but i think in this moment it's not so general, for example i don't see the role of a cron here, the termination reasons should belong to the company policy, no need to add predefined data, we should choose which contract i want to finish, if the employee is a consultant too, having two contract and i want him to remain a consultant, i should have the ability in the wizard to choose the contract to finish, the one2many field from employee should match linked model, termination_ids...the termination reason should have also a note where you can specify conditions that should be respected..the same with the grouping...i suggest to try to relate them to the base groups...when you add groups for each module...it will be a lot of work to configure one user...

@feketemihai
Copy link
Member

Please reopen the PR if it's important to you.

Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants