Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hr_public_holidays to odoo 9 #263

Merged
merged 3 commits into from
Oct 14, 2016
Merged

Conversation

rami-wafaie
Copy link

No description provided.

@pedrobaeza
Copy link
Member

Change version in all the references (manifest, README...)

@pedrobaeza pedrobaeza mentioned this pull request Oct 12, 2016
65 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(code review)

Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, you have my 👍

@@ -32,7 +32,7 @@ public holidays

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/116/8.0
:target: https://runbot.odoo-community.org/runbot/116/9.0

Known issues / Roadmap
======================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rami-wafaie Thanks for porting the module, can you please change the bug tracker link version from 8 to 9.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review - Changes are done as requested

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rami-wafaie Thanks for fixing it.

@pedrobaeza pedrobaeza merged commit 8526fb6 into OCA:9.0 Oct 14, 2016
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-352] Group allow reset rma
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
BSIBSO-1103 exchange connector improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants