-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hr_public_holidays to odoo 9 #263
Conversation
Change version in all the references (manifest, README...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(code review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, you have my 👍
@@ -32,7 +32,7 @@ public holidays | |||
|
|||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | |||
:alt: Try me on Runbot | |||
:target: https://runbot.odoo-community.org/runbot/116/8.0 | |||
:target: https://runbot.odoo-community.org/runbot/116/9.0 | |||
|
|||
Known issues / Roadmap | |||
====================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rami-wafaie Thanks for porting the module, can you please change the bug tracker link version from 8 to 9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review - Changes are done as requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rami-wafaie Thanks for fixing it.
[BSSFL-352] Group allow reset rma
BSIBSO-1103 exchange connector improvements
No description provided.