9.0 mig compute days #270
Merged
9.0 mig compute days #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damdam-s Thanks for your effort in porting the module. Can i ask you to add the code spotted in #265 Thanks a lot. |
|
@feketemihai done. thanks |
|
👍 the code is improved just like in version 10... |
gurneyalex
approved these changes
Oct 26, 2016
pedrobaeza
reviewed
Oct 26, 2016
| @@ -26,6 +27,10 @@ def _check_date_helper(self, employee_id, date): | |||
| return False | |||
| return True | |||
|
|
|||
| @api.onchange('holiday_status_id') | |||
| def _onchange_holiday_status_id(self): | |||
| self._check_and_recompute_days() | |||
There was a problem hiding this comment.
Where is this method defined?
damdam-s
force-pushed
the
9.0-mig_compute_days
branch
5 times, most recently
from
354ac3d
to
243e876
Compare
simahawk
approved these changes
Oct 26, 2016
pedrobaeza
approved these changes
Oct 26, 2016
change version number Update README
fix if no date_from or no date_to
damdam-s
force-pushed
the
9.0-mig_compute_days
branch
from
243e876
to
d472b51
Compare
|
@pedrobaeza squash done |
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[FIX]Change company_xmlid
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #264
thanks @rami-wafaie for initial work