Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 10.0 Porting hr_employee_id #272

Merged
merged 4 commits into from
Nov 13, 2016
Merged

[MIG] 10.0 Porting hr_employee_id #272

merged 4 commits into from
Nov 13, 2016

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 28, 2016

Please notice that I considerably changed the configuration part in order to be compatible with Odoo V10.

@astirpe astirpe mentioned this pull request Oct 28, 2016
Closed
58 tasks
@astirpe
Copy link
Member Author

astirpe commented Oct 28, 2016 •
edited
Loading

Rebased in order to re-launch runbot after #274

@astirpe
[MIG][10.0] Porting hr_employee_id
fd1e507 
Commit 00f4e3d seems causing a warning on runbot:
```
resolve_deps Field hr.holidays.status.is_annual depends on itself; please fix its decorator @api.depends().
```
Fixes #273
feketemihai
feketemihai reviewed Nov 1, 2016
View reviewed changes
Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe @OCA/human-resources-maintainers Andrea, is it too much to ask you to make a method on Apply button to generate Identification Number for existing employees, if they don't have it generated?

hr_employee_id/models/res_company.py
@@ -25,5 +25,5 @@ class ResCompany(models.Model):
employee_id_sequence = fields.Many2one(
comodel_name='ir.sequence',
string='Sequence',
help="Pattern to be used for used for ID Generation",
help="Pattern to be used for used for ID Generation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe Hi Andrea, can you please fix the help message with better description: Pattern to be used for employee ID Generation".

hr_employee_id/models/res_company.py
@@ -25,5 +25,5 @@ class ResCompany(models.Model):
employee_id_sequence = fields.Many2one(
comodel_name='ir.sequence',
string='Sequence',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe Can you update the strign as well: Employee ID Sequence.

hr_employee_id/models/res_config.py
default=5,
help="Number of digits making up the ID"
related='company_id.employee_id_random_digits',
default=_default_id_random_digits
)
employee_id_sequence = fields.Many2one(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe Can you add the model in the field definition...will be more clear...

@feketemihai feketemihai added this to the 10.0 milestone Nov 1, 2016
@feketemihai
Copy link
Member

@astirpe Thanks for your quick reaction. 👍

@astirpe
Copy link
Member Author

astirpe commented Nov 1, 2016 •
edited
Loading

@feketemihai it's possible and easy to add a method on the Apply button. On the other hand, in the past I had a similar experience with a customer: that didn't want to generate the number for existing employees by button; instead they asked to make the field editable in case no value is set already. That solution was better suitable for them, as they were able to fill the field for existing employees with values already defined.

Maybe we could leave this point out of scope for this PR? I could add this point in the readme for the time being, and track the discussion on a separate PR. What do you think?

Thank you!

@feketemihai
Copy link
Member

@astirpe For me it's ok to have this in readme, to know that it will not generate for existing ones...

@espo-tony
Copy link
Contributor

👍

@astirpe
Copy link
Member Author

astirpe commented Nov 13, 2016

Rebased branch in order to re-launch runbot

@pedrobaeza pedrobaeza merged commit 81e84b5 into OCA:10.0 Nov 13, 2016
@astirpe astirpe deleted the 10_port_hr_employee_id branch November 13, 2016 20:07
@Yopli2k
Copy link

Yopli2k commented Nov 22, 2016

Hi, testing v10, especially the new kiosk mode which adds a new field called "barcode". This field has the same meaning as the field ID added by this module. Have you considered using "barcode" field instead of adding a new field?

feketemihai pushed a commit to feketemihai/hr that referenced this pull request Nov 14, 2017
@astirpe
[MIG] 10.0 Porting hr_employee_id (OCA#272)
3ced927
Trivedi-Vacha-SerpentCS pushed a commit to Trivedi-Vacha-SerpentCS/hr that referenced this pull request Jul 4, 2018
@astirpe @Trivedi-Vacha-SerpentCS
[MIG] 10.0 Porting hr_employee_id (OCA#272)
6cb191f
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
Merge pull request OCA#272 from TelmoSenseFly/BSSFL-108
d40e66c 
[BSSFL-108] Initial Inventory
pedrobaeza pushed a commit to Trivedi-Vacha-SerpentCS/hr that referenced this pull request Aug 31, 2018
@astirpe @pedrobaeza
[MIG] 10.0 Porting hr_employee_id (OCA#272)
0a8309f
Trivedi-Vacha-SerpentCS pushed a commit to Trivedi-Vacha-SerpentCS/hr that referenced this pull request Sep 28, 2018
@astirpe @Trivedi-Vacha-SerpentCS
[MIG] 10.0 Porting hr_employee_id (OCA#272)
794493b
alexey-pelykh pushed a commit to brainbeanapps/hr that referenced this pull request Oct 24, 2018
@astirpe @alexey-pelykh
[MIG] 10.0 Porting hr_employee_id (OCA#272)
7ba58b3
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 5, 2019
@astirpe
[MIG] 10.0 Porting hr_employee_id (OCA#272)
02c13fa
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 12, 2019
@astirpe
[MIG] 10.0 Porting hr_employee_id (OCA#272)
5576ea3
damdam-s pushed a commit to damdam-s/hr that referenced this pull request Oct 4, 2019
@astirpe @damdam-s
[MIG] 10.0 Porting hr_employee_id (OCA#272)
2386885
quentingigon pushed a commit to quentingigon/hr that referenced this pull request Oct 11, 2019
@astirpe @quentingigon
[MIG] 10.0 Porting hr_employee_id (OCA#272)
79a4f7e
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
@gurneyalex
Merge pull request OCA#272 from gurneyalex/bsibso-1117
f0130fa 
[BSIBSO-1117] have a customer dependent chrono for analytic accounts
mtelahun pushed a commit to mtelahun/hr that referenced this pull request Jul 14, 2021
@astirpe @mtelahun
[MIG] 10.0 Porting hr_employee_id (OCA#272)
20e82e2
mtelahun pushed a commit to mtelahun/hr that referenced this pull request Nov 10, 2022
@astirpe @mtelahun
[MIG] 10.0 Porting hr_employee_id (OCA#272)
dd614af
mtelahun pushed a commit to mtelahun/hr that referenced this pull request Nov 10, 2022
@astirpe @mtelahun
[MIG] 10.0 Porting hr_employee_id (OCA#272)
d075a90
Chirag-OSI pushed a commit to ursais/hr that referenced this pull request Apr 2, 2024
@astirpe @Chirag-OSI
10.0 Porting hr_employee_id (OCA#272)
5837403
maisim pushed a commit to maisim/hr that referenced this pull request Jun 26, 2024
@astirpe @maisim
[MIG] 10.0 Porting hr_employee_id (OCA#272)
0a74d8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@feketemihai feketemihai feketemihai approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astirpe @feketemihai @espo-tony @Yopli2k @pedrobaeza