Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] hr_payslip_ytd_amount - migrated to 10.0 #278

Closed
wants to merge 7 commits into from
Closed

[MIG] hr_payslip_ytd_amount - migrated to 10.0 #278

wants to merge 7 commits into from

Conversation

bassn
Copy link

@bassn bassn commented Oct 30, 2016

No description provided.

@bassn bassn changed the title Module migration to V10 [MIG] hr_payslip_ytd_amount - migration to Odoo 10 Oct 30, 2016
@bassn bassn changed the title [MIG] hr_payslip_ytd_amount - migration to Odoo 10 [MIG] hr_payslip_ytd_amount - migrated to Odoo 10 Oct 30, 2016
@bassn bassn changed the title [MIG] hr_payslip_ytd_amount - migrated to Odoo 10 [MIG] hr_payslip_ytd_amount - migrated to 10.0 Oct 30, 2016
@pedrobaeza pedrobaeza mentioned this pull request Oct 30, 2016
58 tasks
@ghost
Copy link

ghost commented Oct 31, 2016

👎 seriously @bassn This is wrong. This a copy of module named hr_payslip_ytd_amount that I made in 2014-2015 (openerp version 7.0). You changed the name of the module and replaced existing code with worse code. For example, you should not use direct sql queries in this module.

Also, because you don't mention Savoir-faire Linux's copy rights your files, you are commiting enfrigment to intellectual property.

@pedrobaeza
Copy link
Member

I agree. Closing.

@pedrobaeza pedrobaeza closed this Oct 31, 2016
@bassn
Copy link
Author

bassn commented Oct 31, 2016

@dufresnedavid : Sorry, this is why i already deleted this repo yesterday, after i came about that.
I forgot to delete the PR but the repo was deleted since yesterday

@bassn
Copy link
Author

bassn commented Oct 31, 2016

@dufresnedavid wrote "you should not use sql queries in this module".
You should first stick to your rules before expecting that from other people:
https://github.com/savoirfairelinux/odoo_payroll/blame/9.0/payroll_amount_ytd/models/hr_payslip.py#L43
https://github.com/savoirfairelinux/odoo_payroll/blame/9.0/payroll_amount_ytd/models/hr_payslip.py#L95

@ghost
Copy link

ghost commented Oct 31, 2016

@bassn sorry, forget this, I did write this code myself. I remember now why I did this.

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-365] Fix import repair line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants