Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][hr_emergency_contact] Migration to V9 #296

Merged
merged 4 commits into from
Mar 29, 2018

Conversation

mikevhe18
Copy link

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Nov 25, 2016
65 tasks
@andhit-r
Copy link
Member

andhit-r commented Dec 5, 2016

Code Review: 👍

@azmimr67 please help review

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use Copyright instead of ©
  • Use odoo tag

@feketemihai
Copy link
Member

@mikevhe18 Thanks for the contribution, add yourself in the Contributors list...

@feketemihai feketemihai added this to the 9.0 milestone Feb 23, 2017
Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@azmimr67
Copy link

tested 👍

@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
# © 2011 Michael Telahun Makonnen <mmakonnen@gmail.com>
# © 2016 OpenSynergy Indonesia
# Copytright 2011 Michael Telahun Makonnen <mmakonnen@gmail.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo here: on Copyright :/

<xpath expr='//notebook' position="inside">
<page string="Emergency Contacts">
<field name="emergency_contact_ids" nolabel="1" colspan="4"
context="{'default_is_company':False}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add in the context 'default_customer': False, 'default_supplier': False

@feketemihai feketemihai merged commit 8ed16d6 into OCA:9.0 Mar 29, 2018
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
BSIBSO-1128: Improve report for currency unrealized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants