-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][hr_contract_reference] Migration to V9 #303
Conversation
|
||
<record id="hr_contract_view" model="ir.ui.view"> | ||
<field name="name">hr.contract.form.view.inherit.ref</field> | ||
<field name="model">hr.contract</field> | ||
<field name="type">form</field> | ||
<field name="inherit_id" ref="hr_contract.hr_contract_view_form"/> | ||
<field name="arch" type="xml"> | ||
<field name="name" position="replace"> | ||
<xpath expr="//field[@name='name']" position='replace'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use replace, but position="attributes"
and change attribute readonly
.
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line at the end.
b6e558d
to
e12f20a
Compare
Thanks @pedrobaeza for review. I'll fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Thanks for your contribution
hr_contract_reference/__init__.py
Outdated
# | ||
############################################################################## | ||
# -*- coding: utf-8 -*- | ||
# © 2011,2013 Michael Telahun Makonnen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Copyright instead of ©
hr_contract_reference/__openerp__.py
Outdated
# | ||
############################################################################## | ||
# -*- coding: utf-8 -*- | ||
# © 2011,2013 Michael Telahun Makonnen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Copyright instead of ©
@@ -1,10 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<openerp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use odoo tag
# | ||
############################################################################## | ||
# -*- coding: utf-8 -*- | ||
# © 2011,2013 Michael Telahun Makonnen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Copyright instead of ©
e12f20a
to
4bbe85e
Compare
hr_contract_reference/README.rst
Outdated
* update the module list | ||
* search for "HR Contract Reference" in your addons | ||
* install the module | ||
1. Clone the branch 9.0 of the repository https://github.com/OCA/hr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikevhe18 Thanks for your contribution, can you please fix paragraph, and @pedrobaeza comment...
Minor update
Revision
4bbe85e
to
c006dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
Fix docker-compose PG env variables
No description provided.