Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][hr_contract_reference] Migration to V9 #303

Merged
merged 2 commits into from
Mar 29, 2018

Conversation

mikevhe18
Copy link

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Dec 5, 2016
65 tasks

<record id="hr_contract_view" model="ir.ui.view">
<field name="name">hr.contract.form.view.inherit.ref</field>
<field name="model">hr.contract</field>
<field name="type">form</field>
<field name="inherit_id" ref="hr_contract.hr_contract_view_form"/>
<field name="arch" type="xml">
<field name="name" position="replace">
<xpath expr="//field[@name='name']" position='replace'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use replace, but position="attributes" and change attribute readonly.

</odoo>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line at the end.

@mikevhe18
Copy link
Author

Thanks @pedrobaeza for review. I'll fix it

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks for your contribution

#
##############################################################################
# -*- coding: utf-8 -*-
# © 2011,2013 Michael Telahun Makonnen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Copyright instead of ©

#
##############################################################################
# -*- coding: utf-8 -*-
# © 2011,2013 Michael Telahun Makonnen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Copyright instead of ©

@@ -1,10 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use odoo tag

#
##############################################################################
# -*- coding: utf-8 -*-
# © 2011,2013 Michael Telahun Makonnen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Copyright instead of ©

@feketemihai feketemihai added this to the 9.0 milestone Feb 23, 2017
* update the module list
* search for "HR Contract Reference" in your addons
* install the module
1. Clone the branch 9.0 of the repository https://github.com/OCA/hr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikevhe18 Thanks for your contribution, can you please fix paragraph, and @pedrobaeza comment...

@gurneyalex gurneyalex closed this Oct 2, 2017
@gurneyalex gurneyalex reopened this Oct 2, 2017
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@feketemihai feketemihai merged commit a22c2ba into OCA:9.0 Mar 29, 2018
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
Fix docker-compose PG env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants