[MIG] 10.0 Porting hr_experience #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
leemannd
suggested changes
Feb 22, 2017
| access_hr_experience_officer,hr.experience.officer,model_hr_experience,base.group_hr_user,1,1,1,1 | ||
| access_hr_curriculum_officer,hr_curriculum.officer,model_hr_curriculum,base.group_hr_user,1,1,1,1 | ||
| access_hr_certification_officer,hr.certification.officer,model_hr_certification,base.group_hr_user,1,1,1,1 | ||
| "id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink" |
There was a problem hiding this comment.
These quotes are usesless. Can you remove them?
| <!-- inheritEmployee --> | ||
| <record model="ir.ui.view" id="view_employee_form_inherit"> | ||
| <field name="name">hr.experience.employee.form</field> | ||
| <field name="model">hr.employee</field> | ||
| <field name="inherit_id" ref="hr.view_employee_form"/> | ||
| <field name="arch" type="xml"> | ||
| <notebook position="inside"> | ||
| <page string="Academic Experiences" groups="base.group_user,base.group_hr_user"> | ||
| <page string="Academic Experiences" groups="base.group_user,hr.group_hr_user"> |
There was a problem hiding this comment.
As 'hr.group_hr_user' has the base rights from 'base.group_user' it can be removed.
| @@ -40,7 +41,7 @@ | |||
| </form> | |||
| </field> | |||
| </page> | |||
| <page string="Professional Experiences" groups="base.group_user,base.group_hr_user"> | |||
| <page string="Professional Experiences" groups="base.group_user,hr.group_hr_user"> | |||
There was a problem hiding this comment.
As 'hr.group_hr_user' has the base rights from 'base.group_user' it can be removed
| @@ -64,7 +65,7 @@ | |||
| </form> | |||
| </field> | |||
| </page> | |||
| <page string="Certifications" groups="base.group_user,base.group_hr_user"> | |||
| <page string="Certifications" groups="base.group_user,hr.group_hr_user"> | |||
There was a problem hiding this comment.
As 'hr.group_hr_user' has the base rights from 'base.group_user' it can be removed
|
@jlaloux After functional testing, it is working properly but there are two minor issue to me. |
…nd remove useless group in views
leemannd
reviewed
Feb 24, 2017
hr_experience/models/hr_academic.py
Outdated
| @@ -2,14 +2,16 @@ | |||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>). | |||
| @@ -2,12 +2,12 @@ | |||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>). | |||
| @@ -2,18 +2,18 @@ | |||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>). | |||
hr_experience/models/hr_employee.py
Outdated
| @@ -2,10 +2,10 @@ | |||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>). | |||
| @@ -2,10 +2,10 @@ | |||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>). | |||
hr_experience/README.rst
Outdated
| @@ -83,7 +83,7 @@ help us smashing it by providing a detailed and welcomed `feedback | |||
| <https://github.com/OCA/ | |||
| @@ -4,14 +4,14 @@ | |||
|
|
|||
leemannd
approved these changes
Feb 24, 2017
|
@jlaloux Thanks! |
|
@leemannd With pleasure |
feketemihai
approved these changes
Feb 27, 2017
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-425] Sensefly inc xml_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.