[MIG] hr_employee_phone_extension: Migrated to 10.0 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Feb 22, 2017
leemannd
force-pushed
the
10.0-mig-hr_employee_phone_extension
branch
from
5133433
to
7683f62
Compare
leemannd
changed the title
feketemihai
approved these changes
Feb 23, 2017
leemannd
force-pushed
the
10.0-mig-hr_employee_phone_extension
branch
from
7683f62
to
5d9d3f4
Compare
yvaucher
requested changes
Feb 23, 2017
| @@ -15,7 +15,7 @@ Bug Tracker | |||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_. | |||
| In case of trouble, please check there if your issue has already been reported. | |||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | |||
| `here <https://github.com/OCA/hr/issues/new?body=module:%20hr_employee_phone_extension%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | |||
| `here <https://github.com/OCA/hr/issues/new?body=module:%20hr_employee_phone_extension%0Aversion:%2010.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | |||
There was a problem hiding this comment.
You can remove this link noone uses it anyway.
| #! -*- coding: utf-8 -*- | ||
| # -*- coding: utf-8 -*- | ||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>) | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). |
There was a problem hiding this comment.
No need to add copyright in __init__.py files as long as it contains no code and just imports.
| # | ||
| ############################################################################## | ||
| # -*- coding: utf-8 -*- | ||
| # © 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>) |
There was a problem hiding this comment.
It was decided to keep Copyright in full letters
https://github.com/OCA/maintainer-tools/blob/master/template/module/models/model_name.py#L2
|
|
||
| from openerp import models, fields | ||
| from odoo import models, fields | ||
|
|
||
|
|
||
| class HrEmployee(models.Model): |
There was a problem hiding this comment.
The following fields are limited to 20 characters
Not sure on what this limitation is defined. Numbers can have very difference formats we can even imagine numbers with letters with VoIP.
I think we should drop the size=20
leemannd
force-pushed
the
10.0-mig-hr_employee_phone_extension
branch
from
5d9d3f4
to
ffa3e7e
Compare
leemannd
force-pushed
the
10.0-mig-hr_employee_phone_extension
branch
from
ffa3e7e
to
b3b292f
Compare
|
@yvaucher Updated |
yvaucher
approved these changes
Feb 24, 2017
|
Thanks |
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-430] Fix Invoice compute_sale_orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.