[MIG] hr_contract_reference: Migrated to 10.0 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
force-pushed
the
10.0-mig-hr_contract_reference
branch
2 times, most recently
from
e3816d4
to
7075989
Compare
feketemihai
reviewed
Feb 23, 2017
| @@ -1,5 +1,6 @@ | |||
| .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
There was a problem hiding this comment.
@leemannd Please add yourself in the contribution list...
There was a problem hiding this comment.
@feketemihai It was a really small contribution. Doing it.
leemannd
force-pushed
the
10.0-mig-hr_contract_reference
branch
from
7075989
to
796aa98
Compare
|
@leemannd i agree with you but you spend time reviewing the code, testing it, propesing a PR... |
feketemihai
approved these changes
Feb 23, 2017
yvaucher
approved these changes
Feb 23, 2017
|
|
||
| from openerp import models, fields, api | ||
| from odoo import models, fields, api | ||
|
|
||
|
|
||
| class hr_contract(models.Model): |
There was a problem hiding this comment.
Could you rename the class to camel case
hr_contract_reference/README.rst
Outdated
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | ||
| `here <https://github.com/OCA/hr/issues/new?body=module:%20hr_contract_reference%0Aversion:%2010.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
template to update to last version
andhit-r
approved these changes
Feb 24, 2017
leemannd
force-pushed
the
10.0-mig-hr_contract_reference
branch
from
796aa98
to
5879e24
Compare
|
Updated from comments |
yvaucher
requested changes
Feb 24, 2017
| @@ -13,5 +11,5 @@ | |||
| </field> | |||
There was a problem hiding this comment.
This needs to be a change using position="attributes"
leemannd
force-pushed
the
10.0-mig-hr_contract_reference
branch
from
5879e24
to
d06cdea
Compare
gurneyalex
approved these changes
Feb 28, 2017
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-434] Payment mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.