-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] [MIG] hr_worked_days_from_timesheet #329
[9.0] [MIG] hr_worked_days_from_timesheet #329
Conversation
07952e7
to
8d3a141
Compare
8d3a141
to
b4108ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Also code soft review 👍
Thanks @lreficent 🥇
|
||
* Adds a button to import worked days from timesheet | ||
This module allow you to automatically fill the 'Worked Days' of payslips with | ||
the information of each employee's timesheets for the payslip's period. | ||
|
||
Installation | ||
============ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed
@@ -16,26 +17,23 @@ To install this module, you need to: | |||
* clone the branch 8.0 of the repository https://github.com/OCA/hr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clone the branch 8.0
should be 9.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be 9.0 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please update icon to that of the OCA icon and the Bug Tracker part of Readme with a newer version of it, by removing the following lines
Otherwise LGTM 👍
b4108ad
to
3879830
Compare
@darshan-serpent I just updated the PR with your changes, can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change Otherwise LGTM 👍
@@ -16,26 +17,23 @@ To install this module, you need to: | |||
* clone the branch 8.0 of the repository https://github.com/OCA/hr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be 9.0 here.
3879830
to
1aa4777
Compare
[BSSFL-449] Fix action_split_lots method
Migration to v9: