Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [MIG] hr_worked_days_from_timesheet #329

Merged
merged 1 commit into from
May 31, 2017

Conversation

LoisRForgeFlow
Copy link

Migration to v9:

  • Rename openerp tags.
  • Bump version and update manifest.
  • Adapt code to v9. (new analytic account relation with timesheets).
  • Add a method to check if the contract is set in the payslip.
  • Adapt tests to v9.
  • Update README.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 9.0-mig-hr_worked_days_from_timesheet branch from 07952e7 to 8d3a141 Compare March 30, 2017 15:45
@pedrobaeza pedrobaeza mentioned this pull request Mar 30, 2017
65 tasks
@LoisRForgeFlow LoisRForgeFlow force-pushed the 9.0-mig-hr_worked_days_from_timesheet branch from 8d3a141 to b4108ad Compare March 30, 2017 15:48
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Also code soft review 👍

Thanks @lreficent 🥇


* Adds a button to import worked days from timesheet
This module allow you to automatically fill the 'Worked Days' of payslips with
the information of each employee's timesheets for the payslip's period.

Installation
============

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed

@feketemihai feketemihai added this to the 9.0 milestone May 5, 2017
@@ -16,26 +17,23 @@ To install this module, you need to:
* clone the branch 8.0 of the repository https://github.com/OCA/hr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clone the branch 8.0

should be 9.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 9.0 here.

Copy link
Member

@serpentcs-dev1 serpentcs-dev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update icon to that of the OCA icon and the Bug Tracker part of Readme with a newer version of it, by removing the following lines

Otherwise LGTM 👍

@LoisRForgeFlow LoisRForgeFlow force-pushed the 9.0-mig-hr_worked_days_from_timesheet branch from b4108ad to 3879830 Compare May 30, 2017 10:55
@LoisRForgeFlow
Copy link
Author

@darshan-serpent I just updated the PR with your changes, can you check?

Copy link
Member

@serpentcs-dev1 serpentcs-dev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change Otherwise LGTM 👍

@@ -16,26 +17,23 @@ To install this module, you need to:
* clone the branch 8.0 of the repository https://github.com/OCA/hr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 9.0 here.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 9.0-mig-hr_worked_days_from_timesheet branch from 3879830 to 1aa4777 Compare May 30, 2017 12:17
@dreispt dreispt merged commit f90c82c into OCA:9.0 May 31, 2017
@LoisRForgeFlow LoisRForgeFlow deleted the 9.0-mig-hr_worked_days_from_timesheet branch June 19, 2017 09:34
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-449] Fix action_split_lots method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants