Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added leave accruals module #34

Merged
merged 3 commits into from
Feb 14, 2015
Merged

Added leave accruals module #34

merged 3 commits into from
Feb 14, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2014

This module implements an automatic leave bank computation system.

@pedrobaeza
Copy link
Member

What do you mean by leave bank?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) when pulling e6c6d37 on savoirfairelinux:7.0-ddufresne-leave_banks into d8ab403 on OCA:7.0.

@ghost
Copy link
Author

ghost commented Nov 11, 2014

When an employee works an hour, he may get vacations/ sick days/ legal days allowances. Leave banks is a way to cumulate the allowance (in hours or in cash) for an employee. Do you have another more appropriate term for leave banks?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) when pulling ee7c9b9 on savoirfairelinux:7.0-ddufresne-leave_banks into d8ab403 on OCA:7.0.

max3903
max3903 reviewed Nov 11, 2014
View reviewed changes
hr_leave_banks/__openerp__.py
Adds leave banks on employees.

Whenever a payslip of an employee is computed, the related leave bank records
are writen.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

written

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) when pulling b3fdb19 on savoirfairelinux:7.0-ddufresne-leave_banks into d8ab403 on OCA:7.0.

@max3903
Copy link
Sponsor Member

max3903 commented Nov 12, 2014

👍

@pedrobaeza
Copy link
Member

I would call it "leaves bag" instead "leave bank", but I'm not a native english. Someone can point us?

@ghost
Copy link
Author

ghost commented Nov 13, 2014

I am not native english too. What I am pretty sure is that in french, "Banque de temps" and "Banque de congés" are correct expressions. Sage 50, SAP and JD Edwards seems to use the term "Accrual", as in "vacation or sick leave accruals".

@pedrobaeza
Copy link
Member

Leave accrual seems accurate enough!

@ghost ghost changed the title Added leave banks module Added leave accruals module Nov 14, 2014
@ghost ghost force-pushed the 7.0-ddufresne-leave_banks branch 2 times, most recently from ef14fee to 7d223fe Compare November 26, 2014 13:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.33%) when pulling 7d223fe on savoirfairelinux:7.0-ddufresne-leave_banks into 348505b on OCA:7.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.51%) when pulling 32043bb on savoirfairelinux:7.0-ddufresne-leave_banks into 348505b on OCA:7.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.67%) when pulling 5fa746f on savoirfairelinux:7.0-ddufresne-leave_banks into 348505b on OCA:7.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.56%) when pulling 61bf499 on savoirfairelinux:7.0-ddufresne-leave_banks into 348505b on OCA:7.0.

@ghost ghost mentioned this pull request Dec 26, 2014
Closed
@ghost ghost force-pushed the 7.0-ddufresne-leave_banks branch from 61bf499 to c45e9d9 Compare January 28, 2015 15:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.82%) to 28.61% when pulling c45e9d9 on savoirfairelinux:7.0-ddufresne-leave_banks into 5e2f29e on OCA:7.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.94%) to 28.72% when pulling 2667d8c on savoirfairelinux:7.0-ddufresne-leave_banks into 5e2f29e on OCA:7.0.

@bwrsandman
Copy link

Failing tests

@ghost ghost force-pushed the 7.0-ddufresne-leave_banks branch from cb3619d to 86afe95 Compare February 12, 2015 18:08
@ghost ghost force-pushed the 7.0-ddufresne-leave_banks branch from 86afe95 to 83aa542 Compare February 12, 2015 18:16
@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 29.53% when pulling 83aa542 on savoirfairelinux:7.0-ddufresne-leave_banks into 7363d04 on OCA:7.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.07%) to 29.53% when pulling 83aa542 on savoirfairelinux:7.0-ddufresne-leave_banks into 7363d04 on OCA:7.0.

@bwrsandman bwrsandman added this to the 7.0 milestone Feb 12, 2015
yvaucher
yvaucher reviewed Feb 13, 2015
View reviewed changes
hr_leave_accruals/__openerp__.py
'category': 'Generic Modules/Human Resources',
'description': """
Leave Accruals
===========
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underline is too short. Title could be displayed uncorrectly

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually causes a stderr warning in odoo when installing.

@yvaucher
Copy link
Member

Apart for some nitpicking 👍

@ghost
Copy link
Author

ghost commented Feb 13, 2015

@yvaucher Thanks for your review.

@max3903 max3903 removed the 7.0 label Feb 13, 2015
@max3903 max3903 mentioned this pull request Feb 14, 2015
Closed
7 tasks
max3903 pushed a commit that referenced this pull request Feb 14, 2015
Merge pull request #34 from savoirfairelinux/7.0-ddufresne-leave_banks
e3921e5 
[ADD] leave accruals module
@max3903 max3903 merged commit e3921e5 into OCA:7.0 Feb 14, 2015
@max3903 max3903 deleted the 7.0-ddufresne-leave_banks branch February 14, 2015 18:35
simahawk pushed a commit to camptocamp/hr that referenced this pull request Apr 26, 2017
@gurneyalex
Merge pull request OCA#34 from guewen/bsrtl-165-crm-lead-second-user
c117781 
Add Program Manager on leads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pedrobaeza @coveralls @max3903 @bwrsandman @yvaucher @dreispt