[MIG] Migration module hr_language in 10.0 #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acsonefho
commented
Oct 10, 2017
acsonefho
commented
- Edit views
- Edit ir.model.access
- Split model files (one per model)
- Edit manifest
- Edit readme
- Edit translations
Jerther
suggested changes
Nov 10, 2017
There was a problem hiding this comment.
Tested on runbot, and works fine.
Please consider reviewing OCA/project#328
| "website": "http://www.savoirfairelinux.com", | ||
| "depends": [ | ||
| "hr", | ||
| ], | ||
| 'data': [ | ||
| 'security/ir.model.access.csv', | ||
| 'views/hr_language_view.xml', | ||
| 'views/hr_employee.xml', | ||
| 'views/hr_language.xml', | ||
| ], | ||
| "demo": [], |
There was a problem hiding this comment.
demo is empty and could be removed.
| # -*- coding: utf-8 -*- | ||
| # Copyright (C) 2017-Today: Odoo Community Association (OCA) | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
| from odoo import models, fields |
There was a problem hiding this comment.
imports should be alphabetically sorted
| # -*- coding: utf-8 -*- | ||
| # Copyright (C) 2017-Today: Odoo Community Association (OCA) | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
| from odoo import models, fields, tools |
There was a problem hiding this comment.
imports should be alphabetically sorted
| @@ -250,6 +251,11 @@ msgid "Languages" | |||
| msgstr "Langues" | |||
|
|
|||
| #. module: hr_language | |||
| #: help:hr.employee,language_ids:0 | |||
| msgid "Languages of this employee" | |||
| msgstr "Languages de cet employé" | |||
There was a problem hiding this comment.
"Langues de cet employé".
"Language" translates to "Langue" in french, as "Langage" (and not "Language") has a different meaning.
So this should be fixed everythere in the french translation.
gurneyalex
approved these changes
Mar 26, 2018
|
merged in 3fba7bd |
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-441] Payment details on Quotation / Sale report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.