[11.0][MIG] hr_holidays_settings #445
Conversation
|
Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex
|
@pedrobaeza Squashed them :) |
| data-key="hr_holidays" groups="hr.group_hr_manager"> | ||
| <h2>Leaves Management</h2> | ||
| <div class="row mt16 o_settings_container" title="Leaves Management"> | ||
|
|
There was a problem hiding this comment.
why do you put the empty div in here? Can we remove it?
There was a problem hiding this comment.
We can remove it. But this way we have a 'default section' for settings. People who depend on this module can just add a div with class o_setting_box to extend it.
|
@tarteo @pedrobaeza Do you think one should be autoinstalled, if you install hr_holidays? |
|
Well, this is not needed unless you install one module that uses it, so better to let it not auto-installed, but installed as dependency when installing one of the other modules. |
| { | ||
| "name": "HR Holidays Settings", | ||
| "summary": "Enables Settings Form for HR Holidays.", | ||
| "version": "11.0.1.1.0", |
There was a problem hiding this comment.
should have been 11.0.1.0.0
No description provided.