Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][11.0]hr_contract_reference-Migration to 11.0. #456

Merged
merged 19 commits into from
Oct 11, 2018
Merged

[MIG][11.0]hr_contract_reference-Migration to 11.0. #456

merged 19 commits into from
Oct 11, 2018

Conversation

Trivedi-Vacha-SerpentCS
Copy link

@Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS commented Jul 3, 2018 •
edited
Loading

[MIG][11.0]hr_contract_reference-Migration to 11.0.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 3, 2018
@pedrobaeza pedrobaeza mentioned this pull request Jul 3, 2018
Closed
71 tasks
@Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS changed the title [Mig][11.0]hr_contract_reference-Migration to 11.0. [MIG][11.0]hr_contract_reference-Migration to 11.0. Jul 3, 2018
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
@yvaucher
Merge pull request OCA#456 from TDu/bssfw-40
f638851 
BSSFW-40 Add serial_owner
nikul-serpentcs
nikul-serpentcs reviewed Sep 5, 2018
View reviewed changes
hr_contract_reference/data/hr_contract_sequence.xml Outdated
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data noupdate="1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trivedi-Vacha-SerpentCS IMHO Direct use <odoo noupdate="1">.

@oca-clabot
Copy link

Hey @Trivedi-Vacha-SerpentCS, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

nikul-serpentcs
nikul-serpentcs approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

@pedrobaeza
Copy link
Member

Can you please squash a bit commit history (specially those that are duplicated message).

@Trivedi-Vacha-SerpentCS
Copy link
Author

@pedrobaeza squash bit difficult, because I added preserve also so no need to squash here.

@pedrobaeza
Copy link
Member

Well, I'm seeing unrelated commits like "[UPD] Update hr_holidays_public.pot", and also a lot of duplicated commits, like:

seleccion_001

@Trivedi-Vacha-SerpentCS
Copy link
Author

Trivedi-Vacha-SerpentCS commented Oct 1, 2018 •
edited
Loading

@pedrobaeza Squash done, Ready to Merge

espo-tony
espo-tony suggested changes Oct 1, 2018
View reviewed changes
hr_contract_reference/models/hr_contract.py Outdated

@api.model
def create(self, vals):
if vals.get('number', '/') == '/':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think number here should rather be name

@Trivedi-Vacha-SerpentCS
Copy link
Author

@espo-tony Fixed Code, please add review
@pedrobaeza Squash done, Ready to Merge

@pedrobaeza pedrobaeza merged commit 8b0fd04 into OCA:11.0 Oct 11, 2018
@Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS deleted the 11.0-hr_contract_reference branch September 4, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espo-tony espo-tony espo-tony approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet