[12.0][ADD] hr_holidays_accrual_advanced: Advanced accrual leave allocations

[alexey-pelykh]

[pedrobaeza]

Please add usage and configuration instructions to the README for this being reviewable.

[alexey-pelykh]

Depends on #502

[alexey-pelykh]

@pedrobaeza you've mentioned somewhere (if I remember correctly) that Odoo integrated some of the modules from the OCA, right? If yes, what's the procedure of submission except for the PR submission? Since current accrual leaves implementation in Odoo itself, well, not ok by many reasons, lightly speaking.

[pedrobaeza]

Yes, you can make a PR over master branch with the added feature to an existing module. New modules will be surely rejected, but new features might be considered if they fit well with the guidelines, cover a general functional gap, and it's well explained.

[alexey-pelykh]

@pedrobaeza because changes were requested on the PR:

and they were addressed :)

[pedrobaeza]

Well, then you know more than me...

[alexey-pelykh]

@pedrobaeza let me rephrase my question: I need one more review, preferably functional one, to get this PR merged?

[nikul-serpentcs]

@pedrobaeza And One more general Question: In Some repo. not added maintainer group like @OCA/accounting-maintainers

If Added maintainers groups then it's look like freeze or not quick responce

[pedrobaeza]

@nikul-serpentcs pinging a group makes the message to get to that group, but this doesn't guarantee any reaction, and sometimes the maintainer group is very small (because people haven't applied for this role).

[pedrobaeza]

@nikul-serpentcs the procedure for being in a team is not that one, as it requires some external steps. See the guide https://odoo-community.org/page/oca-project-steering-committee-guide and apply on contributors@odoo-community.org with your merits.

[nikul-serpentcs]

@pedrobaeza I think here we create all repo. maintainer group/team (like a HR-maintainer group, Project- maintainer group and so..)
And Active Reviewer Or Person directly add in our group

[nikul-serpentcs]

because people haven't applied for this role

@pedrobaeza How I can apply for a maintainer?
Many time I sent Join Request here https://github.com/orgs/OCA/teams/website-maintainers/members or https://github.com/orgs/OCA/teams/accounting-maintainers/members
But, Not any replay or avoid my request.

[pedrobaeza]

I have already told you.

[nikul-serpentcs]

I have already told you.

Ok, I See

@nikul-serpentcs the procedure for being in a team is not that one, as it requires some external steps. > See the guide https://odoo-community.org/page/oca-project-steering-committee-guide and apply on
contributors@odoo-community.org with your merits.

It's Too long process 😄

[sswapnesh]

LGTM apart from comments I have added (But they are not major ones)

[rafaelbn]

Could we merge this? 3 approvals just missing 1 PSC

[pedrobaeza]

The only issue I have right now is the module name, as accrual system already exists on core, so this is suggesting the contrary. I know we must avoid the word extension, but right now the only suitable name I find is hr_holidays_accrual_extension. Or any other suggestion?

[alexey-pelykh]

@pedrobaeza it's so rudiment in core that calling it accrual system would be an overstatement. To very essence, it's not an extension, it's a replacement. Literally, this module does it's own computation, reusing nothing from core "accrual system"

[pedrobaeza]

Well, I don't like too much that revelation, but OK, let's call it hr_holidays_accrual_alternative, and you must mention this in the README.

[alexey-pelykh]

@pedrobaeza as is from readme:
This module provides advanced accrual leaves allocation as extension to
out-of-the-box per-employee accrual leave allocation capabilities of Odoo,
introducing following extra features:

• Accrual allocation history
• Accrual allocation calculator ("How many leave days I'll have in 3 months from today?")
• Various accrual methods
• Various limits to express complex corporate accrual leave policies
• Takes into account employee service period instead of create_date

Regarding module name, I think hr_holidays_advanced_accruement?

[pedrobaeza]

Yeah, but you have just told me that this replaces standard, not extend it, so the README is incorrect, and in any case the name would be hr_holidays_accrual_advanced (not English order, but module + model + feature order).

[alexey-pelykh]

@pedrobaeza technically, it does replace the calculation (since there was no way to extend it), but it's still backwards compatible, so for user experience it's an advanced extension.

[pedrobaeza]

I insist, you should mention that "technical" detail, at least in known issues, but go with hr_holidays_accrual_advanced name.

[alexey-pelykh]

@pedrobaeza added that to ROADMAP.rst though I'd argue it's has anything to do with roadmap or known issues, and renamed the module

[sswapnesh]

Finally 📯 🎆