[11.0][MIG] hr_job_category #538

i-vyshnevska · 2019-01-03T09:29:38Z

Migration of module hr_job_categories to v11

oca-clabot · 2019-01-03T09:29:40Z

Hey @i-vyshnevska, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@i-vyshnevska (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2019-01-03T09:30:22Z

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

nikul-serpentcs

Improve Code

hr_job_categories/__init__.py

hr_job_categories/__manifest__.py

hr_job_categories/models/__init__.py

hr_job_categories/models/hr.py

simahawk

pls squash these commits together

also, pls include module name in your commits, like [XYZ] hr_job_categories: do something

simahawk · 2019-01-03T14:04:37Z

hr_job_categories/models/hr.py

+        job = self.env['hr.job'].browse(job_id)
+        _logger.debug('Removing employee tags if tag exists on contract '
+                      'job: %s', empl_tags)
+        for tag in job.category_ids:


Refactoring is out of the scope of the PR but pls add a TODO comment to refactor these methods to write only once.

simahawk · 2019-01-08T07:42:48Z

@nikul-serpentcs can you update your review?

nikul-serpentcs

Code review LGTM 👍

@i-vyshnevska using oca-gen-addon-readme and create Readme file

https://github.com/OCA/maintainer-tools/tree/master/template/module/readme

OCA-git-bot · 2019-01-08T11:30:59Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

The name should be in singular. For example, hr_job_multi_category, and README should be at least in new format (but README by fragments is recommended).

simahawk · 2019-01-09T08:17:47Z

@i-vyshnevska am I wrong or the README is outgenerated but the the readme folder is not here?

simahawk · 2019-01-09T12:08:29Z

@pedrobaeza sounds good now

pedrobaeza · 2019-01-09T12:49:49Z

hr_job_category/README.rst

+
+To install this module, you need to:
+
+* clone the branch 8.0 of the repository https://github.com/OCA/hr


Outdated instructions, but this shouldn't even be there as they are generic instructions.

@pedrobaeza I don't see it in the fragment.
Although, there's no reason to explain the cloning etc.

@pedrobaeza @simahawk sorry guys, my bad,
seems ok now

Then don't touch yourself the file, but generate it with the OCA/maintainer-tools script.

nikul-serpentcs

Minor change

nikul-serpentcs · 2019-01-10T04:06:47Z

hr_job_category/__manifest__.py

@@ -0,0 +1,20 @@
+


@i-vyshnevska Add license/Copyright

nikul-serpentcs · 2019-01-10T04:07:49Z

hr_job_category/tests/test_hr_job_categories.py

@@ -0,0 +1,57 @@
+


nikul-serpentcs · 2019-01-10T04:08:06Z

hr_job_category/models/hr.py

@@ -0,0 +1,72 @@
+


Tonow-c2c

Just minor already asked but after that code LGTM

Tonow-c2c · 2019-01-10T08:04:09Z

hr_job_category/__init__.py

@@ -0,0 +1,2 @@
+


in init file you can remove the fist line

the next time you can use find . -name "*.py" -exec sed -i "/#.*coding\: /d" {} \; to help you it's on section https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0#tasks-to-do-in-the-migration

Tonow-c2c · 2019-01-10T08:06:57Z

hr_job_category/models/hr.py

+    def write(self, vals):
+        prev_data = self.read(['job_id'])
+
+        res = super(HRContract, self).write(vals)


In python3 I think no need HRContract, self in super but it's works well to

travis somehow better works with self )

@i-vyshnevska this is not something of Travis, but Python version syntax.

@pedrobaeza sorry for so much pain from my PR, it seems ok now

simahawk · 2019-01-14T07:18:22Z

gentlemen, all good now?

oca-clabot · 2019-02-20T12:59:17Z

Hey @i-vyshnevska,
We acknowledge that the following users have signed our Contributor License Agreement:

@i-vyshnevska

Appreciation of efforts,
OCA CLAbot

nikul-serpentcs suggested changes Jan 3, 2019

View reviewed changes

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from 9e1becb to 548697c Compare January 3, 2019 10:56

miketelahun and others added 12 commits January 3, 2019 14:26

Bugfix: Add hr_job_categories. Other modules depend on it.

76b6e67

[FIX] PEP8

d4b7b71

Initialize 8.0 branch

30a7910

Update code, fix tests, add readme.

0a9da4c

Fix travis errors.

fc32889

Add icon file.

334867b

Modify author to short company name.

392e6d7

Port tests to new api.

6f96fb6

Fix tad typo.

f86c277

Remove blank line in tests.

c9d2a94

OCA Transbot updated translations from Transifex

b29bc2c

[UPD] prefix versions with 8.0

d7b4180

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from 548697c to 684c115 Compare January 3, 2019 12:40

simahawk requested changes Jan 3, 2019

View reviewed changes

oca-transbot and others added 3 commits January 3, 2019 16:09

OCA Transbot updated translations from Transifex

6e61325

[MIG] Make modules uninstallable

81b9535

[MIG] Rename manifest files

1ddde22

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch 2 times, most recently from 98b4a89 to b3745cd Compare January 4, 2019 13:55

simahawk approved these changes Jan 7, 2019

View reviewed changes

nikul-serpentcs approved these changes Jan 8, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 8, 2019

pedrobaeza requested changes Jan 8, 2019

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jan 8, 2019

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from b3745cd to 7446041 Compare January 8, 2019 23:39

i-vyshnevska changed the title ~~[11.0][MIG] hr_job_categories~~ [11.0][MIG] hr_job_category Jan 8, 2019

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from 7446041 to e525c0f Compare January 8, 2019 23:42

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from e525c0f to 08fbebe Compare January 9, 2019 08:40

pedrobaeza reviewed Jan 9, 2019

View reviewed changes

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from 08fbebe to d850e8e Compare January 9, 2019 14:11

nikul-serpentcs suggested changes Jan 10, 2019

View reviewed changes

Tonow-c2c approved these changes Jan 10, 2019

View reviewed changes

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch 2 times, most recently from 7ef16e4 to 0f42c8c Compare January 10, 2019 09:46

[MIG] hr_job_category: Migrate to 11.0

e361b84

i-vyshnevska force-pushed the 11.0-mig-hr_job_categories branch from 0f42c8c to e361b84 Compare January 11, 2019 13:05

pedrobaeza approved these changes Jan 14, 2019

View reviewed changes

pedrobaeza added this to the 11.0 milestone Jan 14, 2019

gurneyalex merged commit 1371ecb into OCA:11.0 Jan 16, 2019

OCA-git-bot mentioned this pull request Jan 16, 2019

Migration to version 12.0 #479

Closed

32 tasks

jarroyomorales mentioned this pull request Sep 26, 2019

Migration to version 11.0 #374

Closed

71 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] hr_job_category #538

[11.0][MIG] hr_job_category #538

i-vyshnevska commented Jan 3, 2019

oca-clabot commented Jan 3, 2019

pedrobaeza commented Jan 3, 2019

nikul-serpentcs left a comment

simahawk left a comment •

edited

Loading

simahawk Jan 3, 2019

simahawk commented Jan 8, 2019

nikul-serpentcs left a comment

OCA-git-bot commented Jan 8, 2019

pedrobaeza left a comment

simahawk commented Jan 9, 2019 •

edited

Loading

simahawk commented Jan 9, 2019

pedrobaeza Jan 9, 2019

simahawk Jan 9, 2019

i-vyshnevska Jan 9, 2019

pedrobaeza Jan 9, 2019

nikul-serpentcs left a comment

nikul-serpentcs Jan 10, 2019

nikul-serpentcs Jan 10, 2019

nikul-serpentcs Jan 10, 2019

Tonow-c2c left a comment

Tonow-c2c Jan 10, 2019

Tonow-c2c Jan 10, 2019

i-vyshnevska Jan 11, 2019

pedrobaeza Jan 11, 2019

i-vyshnevska Jan 11, 2019

simahawk commented Jan 14, 2019

oca-clabot commented Feb 20, 2019


		To install this module, you need to:

		* clone the branch 8.0 of the repository https://github.com/OCA/hr

[11.0][MIG] hr_job_category #538

[11.0][MIG] hr_job_category #538

Conversation

i-vyshnevska commented Jan 3, 2019

oca-clabot commented Jan 3, 2019

pedrobaeza commented Jan 3, 2019

nikul-serpentcs left a comment

Choose a reason for hiding this comment

simahawk left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Jan 8, 2019

nikul-serpentcs left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 8, 2019

pedrobaeza left a comment

Choose a reason for hiding this comment

simahawk commented Jan 9, 2019 • edited Loading

simahawk commented Jan 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tonow-c2c left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Jan 14, 2019

oca-clabot commented Feb 20, 2019

simahawk left a comment •

edited

Loading

simahawk commented Jan 9, 2019 •

edited

Loading