Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] hr_job_category #542

Closed
wants to merge 4 commits into from

Conversation

Nikul-Chaudhary
Copy link
Member

HR Job Employee Categories

This module was written to extend the functionality of jobs to support tagging employees based on their job positions. For example, all Supervisors could be attached to the Supervisors category.Define which categories a job belongs to in the configuration for the job. When an employee is assigned a particular job the categories attached to that job will be attached to the employee record as well.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Jan 20, 2019
32 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 20, 2019
@alexey-pelykh
Copy link
Contributor

I think #548 is important to keep track of

<field name="inherit_id" ref="hr.view_hr_job_form"/>
<field name="arch" type="xml">
<xpath expr="//div[hasclass('oe_title')]" position="inside">
<label for="category_ids" class="oe_edit_only" groups="base.group_hr_manager"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for #548 to be merged or just cherry-pick it's commit to fix the issue mentioned in runbot

@Nikul-Chaudhary
Copy link
Member Author

I think #548 is important to keep track of

@alexey-pelykh Yes, Sure

@i-vyshnevska
Copy link
Member

I think #548 is important to keep track of

@alexey-pelykh Yes, Sure

#548 merget you can pick it

Copy link
Member

@i-vyshnevska i-vyshnevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-vyshnevska
Copy link
Member

and you add yourself as author if you made some code improvements

@pedrobaeza
Copy link
Member

and you add yourself as author if you made some code improvements

It would contributor, not author. For being co-author you have to do big code changes/feature addition

@Nikul-Chaudhary
Copy link
Member Author

@alexey-pelykh @i-vyshnevska @pedrobaeza Cherry-Picked commits, Could you please review again.

@Nikul-Chaudhary
Copy link
Member Author

you doh't keep history please migrate with using https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0#technical-method-to-migrate-a-module-from-100-to-110-branch

@i-vyshnevska No need to this, Only Cherry-Pick commits

@Nikul-Chaudhary
Copy link
Member Author

and you add yourself as author if you made some code improvements

It would contributor, not author. For being co-author you have to do big code changes/feature addition

Noted!!

@tbaden
Copy link
Member

tbaden commented Apr 26, 2019

@alexey-pelykh this looks resolved, could you please check this pr again.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

job = self.env['hr.job'].browse(job_id)
for tag in job.category_ids:
if tag not in empl_tags:
_logger.debug("Adding employee tag if job tag doesn't "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this message necessary?

Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@jarroyomorales
Copy link

@pedrobaeza @jbeficent @alexey-pelykh Can we merge this?

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-542-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a6214ab. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Aug 14, 2019
Signed-off-by pedrobaeza
@Nikul-Chaudhary Nikul-Chaudhary deleted the 12-hr_job_category branch September 19, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants