-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] [MIG] hr_job_category #542
Conversation
I think #548 is important to keep track of |
hr_job_category/views/hr_view.xml
Outdated
<field name="inherit_id" ref="hr.view_hr_job_form"/> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//div[hasclass('oe_title')]" position="inside"> | ||
<label for="category_ids" class="oe_edit_only" groups="base.group_hr_manager"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for #548 to be merged or just cherry-pick it's commit to fix the issue mentioned in runbot
@alexey-pelykh Yes, Sure |
#548 merget you can pick it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you doh't keep history please migrate with using https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0#technical-method-to-migrate-a-module-from-100-to-110-branch
and you add yourself as author if you made some code improvements |
It would contributor, not author. For being co-author you have to do big code changes/feature addition |
43fa54a
to
e8a0adc
Compare
@alexey-pelykh @i-vyshnevska @pedrobaeza Cherry-Picked commits, Could you please review again. |
@i-vyshnevska No need to this, Only Cherry-Pick commits |
Noted!! |
@alexey-pelykh this looks resolved, could you please check this pr again. |
This PR has the |
job = self.env['hr.job'].browse(job_id) | ||
for tag in job.category_ids: | ||
if tag not in empl_tags: | ||
_logger.debug("Adding employee tag if job tag doesn't " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this message necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM 👍
@pedrobaeza @jbeficent @alexey-pelykh Can we merge this? |
/ocabot merge |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at a6214ab. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
HR Job Employee Categories
This module was written to extend the functionality of jobs to support tagging employees based on their job positions. For example, all Supervisors could be attached to the Supervisors category.Define which categories a job belongs to in the configuration for the job. When an employee is assigned a particular job the categories attached to that job will be attached to the employee record as well.