[MIG][11.0] hr attendance reason #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarroyomorales
force-pushed
the
11.0-mig-hr_attendance_reason
branch
3 times, most recently
from
6584ff4
to
05a9b5f
Compare
etobella
requested changes
May 2, 2019
| name = fields.Char( | ||
| String='Reason', | ||
| help='Specifies the reason leaving soon or arriving late', | ||
| required=True, index=True) | ||
| code = fields.Char('Reason Code') | ||
| action_type = fields.Selection( | ||
| [('sign_in', 'Sign in'), |
There was a problem hiding this comment.
Do not change the name without a migration script please.
You can make the script or keep the old name.
There was a problem hiding this comment.
Okay, I will keep sign in and sign out then.
hr_attendance_reason/i18n/es.po
Outdated
| @@ -0,0 +1,129 @@ | |||
| # Translation of Odoo Server. | |||
There was a problem hiding this comment.
It's better to maintain the translation directly on weblate
hr_attendance_reason/README.rst
Outdated
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/hr/tree/10.0/hr_attendance_reason | ||
| :alt: OCA/hr | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr_attendance_reason-lightgray.png?logo=github |
There was a problem hiding this comment.
Could you split the readme with the new standard model please? 😉
There was a problem hiding this comment.
Sorry, it is splitted. I didn't notice it
jarroyomorales
force-pushed
the
11.0-mig-hr_attendance_reason
branch
from
05a9b5f
to
23f2665
Compare
tbaden
approved these changes
May 2, 2019
jarroyomorales
force-pushed
the
11.0-mig-hr_attendance_reason
branch
3 times, most recently
from
82249af
to
e858e3e
Compare
jarroyomorales
force-pushed
the
11.0-mig-hr_attendance_reason
branch
from
e858e3e
to
de4c6b5
Compare
etobella
approved these changes
May 3, 2019
luistorresm
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of hr_attendance_reason to 11.0.