-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][11.0] hr_employee_seniority #589
Conversation
Hey @jarroyomorales, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
5fd9123
to
dc188c8
Compare
dc188c8
to
258b4c9
Compare
258b4c9
to
6863946
Compare
@luistorresm Changes done, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Technical review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
6863946
to
e968753
Compare
ping @nikul-serpentcs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Code Review 👍
This PR has the |
Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
… service Make it searchable and put it up on the employee tree view. Also, make it accessable only to base.group_hr_user and hr_security.group_payroll_manager. Move initial_employment_date of hr.employee from hr_policy_accrual into this module. Also, for some reason the view was declared in hr_payroll_period, so move that here as well.
…_date and seniority Apparantly the ORM doesn't hide just the field, it hides the entire object. So, this just makes it too much of a hassle.
normally hr.contract are only readable by Employee / Officer and Employee / Managers, not basic employees => we need compute_sudo to compute the employee's seniority otherwise the employee cannot display his own record.
Currently translated at 100.0% (5 of 5 strings) Translation: hr-10.0/hr-10.0-hr_employee_seniority Translate-URL: https://translation.odoo-community.org/projects/hr-10-0/hr-10-0-hr_employee_seniority/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-10.0/hr-10.0-hr_employee_seniority Translate-URL: https://translation.odoo-community.org/projects/hr-10-0/hr-10-0-hr_employee_seniority/
e968753
to
f1ca390
Compare
@pedrobaeza Done! |
Migration to 11.0 of hr_employee_seniority