Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][11.0] hr_employee_seniority #589

Merged
merged 22 commits into from
May 13, 2019

Conversation

jarroyomorales
Copy link

Migration to 11.0 of hr_employee_seniority

@oca-clabot
Copy link

Hey @jarroyomorales, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@jarroyomorales jarroyomorales reopened this May 3, 2019
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_employee_seniority branch 2 times, most recently from 5fd9123 to dc188c8 Compare May 3, 2019 08:07
@pedrobaeza pedrobaeza added this to the 11.0 milestone May 3, 2019
@pedrobaeza pedrobaeza mentioned this pull request May 3, 2019
71 tasks
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_employee_seniority branch from dc188c8 to 258b4c9 Compare May 3, 2019 09:31
hr_employee_seniority/models/hr_employee.py Outdated Show resolved Hide resolved
hr_employee_seniority/models/hr_employee.py Outdated Show resolved Hide resolved
hr_employee_seniority/models/hr_employee.py Outdated Show resolved Hide resolved
hr_employee_seniority/models/hr_employee.py Outdated Show resolved Hide resolved
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_employee_seniority branch from 258b4c9 to 6863946 Compare May 6, 2019 06:18
@jarroyomorales
Copy link
Author

@luistorresm Changes done, thank you!

Copy link
Contributor

@luistorresm luistorresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Technical review

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

hr_employee_seniority/__manifest__.py Outdated Show resolved Hide resolved
@etobella
Copy link
Member

etobella commented May 9, 2019

ping @nikul-serpentcs

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Code Review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

miketelahun and others added 7 commits May 13, 2019 10:35
… service

Make it searchable and put it up on the employee tree view. Also, make it accessable
only to base.group_hr_user and hr_security.group_payroll_manager.

Move initial_employment_date of hr.employee from hr_policy_accrual into this module. Also, for some
reason the view was declared in hr_payroll_period, so move that here as well.
…_date and seniority

Apparantly the ORM doesn't hide just the field, it hides the entire object. So, this just makes
it too much of a hassle.
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_employee_seniority branch from e968753 to f1ca390 Compare May 13, 2019 08:36
@jarroyomorales
Copy link
Author

@pedrobaeza Done!

@pedrobaeza pedrobaeza merged commit d4d63ca into OCA:11.0 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet