-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][11.0] hr_attendance_autoclose #591
[MIG][11.0] hr_attendance_autoclose #591
Conversation
<field name="interval_number">1</field> | ||
<field name="interval_type">hours</field> | ||
<field name="numbercall">-1</field> | ||
<field name="nextcall" eval="(DateTime.now() + timedelta(minutes=60)).strftime('%Y-%m-%d %H:05:00')"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having problems with this. The field seems to be computing properly but after some testing it looks like the cron is ignoring this value and executing 1 hour after the last one finished and not at 10:05, 11:05, 12:05 as it should. I don't know if this trick has stopped working on 11.0 or I am doing something wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is standard Odoo. The next execution time is calculated when the cron is finished, instead the previous execution time. Hope they change that in future versions.
fbd2b44
to
f5fb4bd
Compare
f5fb4bd
to
d6cdfc4
Compare
6082f7d
to
e7312c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking
e7312c2
to
e86b951
Compare
@nikul-serpentcs Changes attended |
e86b951
to
f7058bc
Compare
'category': 'Human Resources', | ||
'summary': 'Close stale Attendances', | ||
'website': 'https://github.com/OCA/hr', | ||
'author': 'Odoo Community Association (OCA)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aheficent can you please check author name it's right 'author': 'Eficent, Odoo Community Association (OCA)',
or keep as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine as it is as the copyright in the files. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Code Review
LGTM 👍
Migration of hr_attendance_autoclose to 11.0