Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][11.0] hr_attendance_autoclose #591

Merged
merged 4 commits into from
May 15, 2019

Conversation

jarroyomorales
Copy link

Migration of hr_attendance_autoclose to 11.0

<field name="interval_number">1</field>
<field name="interval_type">hours</field>
<field name="numbercall">-1</field>
<field name="nextcall" eval="(DateTime.now() + timedelta(minutes=60)).strftime('%Y-%m-%d %H:05:00')"/>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having problems with this. The field seems to be computing properly but after some testing it looks like the cron is ignoring this value and executing 1 hour after the last one finished and not at 10:05, 11:05, 12:05 as it should. I don't know if this trick has stopped working on 11.0 or I am doing something wrong.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is standard Odoo. The next execution time is calculated when the cron is finished, instead the previous execution time. Hope they change that in future versions.

@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_attendance_autoclose branch from fbd2b44 to f5fb4bd Compare May 6, 2019 09:54
@pedrobaeza pedrobaeza added this to the 11.0 milestone May 6, 2019
@pedrobaeza pedrobaeza mentioned this pull request May 6, 2019
71 tasks
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_attendance_autoclose branch from f5fb4bd to d6cdfc4 Compare May 8, 2019 12:11
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_attendance_autoclose branch 2 times, most recently from 6082f7d to e7312c2 Compare May 9, 2019 06:24
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking

hr_attendance_autoclose/data/hr_attendance.xml Outdated Show resolved Hide resolved
hr_attendance_autoclose/models/hr_attendance.py Outdated Show resolved Hide resolved
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_attendance_autoclose branch from e7312c2 to e86b951 Compare May 15, 2019 11:33
@jarroyomorales
Copy link
Author

@nikul-serpentcs Changes attended

@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_attendance_autoclose branch from e86b951 to f7058bc Compare May 15, 2019 12:19
'category': 'Human Resources',
'summary': 'Close stale Attendances',
'website': 'https://github.com/OCA/hr',
'author': 'Odoo Community Association (OCA)',
Copy link
Member

@nikul-serpentcs nikul-serpentcs May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aheficent can you please check author name it's right 'author': 'Eficent, Odoo Community Association (OCA)', or keep as it is.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine as it is as the copyright in the files. Thanks.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Code Review
LGTM 👍

@JordiBForgeFlow JordiBForgeFlow merged commit c1ff709 into OCA:11.0 May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants