Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] hr_employee_display_own_info #592

Merged
merged 6 commits into from
May 13, 2019
Merged

[11.0][MIG] hr_employee_display_own_info #592

merged 6 commits into from
May 13, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented May 7, 2019

This is the backport of hr_employee_display_own_info from V12 (#582) to V11.

tbaden
tbaden approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: lgtm
If you like an optional change

hr_employee_display_own_info/views/hr_employee.xml Outdated Show resolved Hide resolved
etobella
etobella approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 11.0 milestone May 13, 2019
@pedrobaeza pedrobaeza merged commit 3051134 into OCA:11.0 May 13, 2019
@astirpe astirpe deleted the 11_backport_hr_employee_display_own_info branch May 13, 2019 08:01
@pedrobaeza pedrobaeza mentioned this pull request May 13, 2019
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@astirpe @OCA-git-bot @tbaden @etobella @pedrobaeza @oca-travis