Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] hr_contract_default_trial_length #645

Merged
merged 14 commits into from
Mar 10, 2020

Conversation

jarroyomorales
Copy link

Migration to 11.0 of hr_contract_default_trial_length.
Minor changes, added tests and split the readme.

@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_contract_default_trial_length branch from 5c39220 to 5706513 Compare July 24, 2019 07:47
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments to attend 😉 👍

hr_contract_default_trial_length/__init__.py Outdated Show resolved Hide resolved
@jarroyomorales jarroyomorales force-pushed the 11.0-mig-hr_contract_default_trial_length branch from 5706513 to 65a623c Compare July 24, 2019 08:47
@jarroyomorales
Copy link
Author

@etobella Comments attended

@jarroyomorales jarroyomorales mentioned this pull request Sep 26, 2019
71 tasks
@ovnicraft
Copy link
Member

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jarroyomorales
Copy link
Author

@alexey-pelykh Can this be merged?

@ovnicraft
Copy link
Member

@jarroyomorales planned mig to 12.0? 💥

@jarroyomorales
Copy link
Author

@ovnicraft Sure! I will after getting this one merged

@dreispt
Copy link
Sponsor Member

dreispt commented Mar 10, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-645-by-dreispt-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a92dcd7 into OCA:11.0 Mar 10, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2ae1d6c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet