ported hr_webcam to 8.0 #65

yoyo2k · 2015-01-15T12:29:49Z

updated __openerp__.py and hr_webcam_view.xml to reflect changes to 8.0 api
modified hr_webcam.css (wider camera viewport)

- updated __openerp__.py and hr_webcam_view.xml to reflect changes to 8.0 api - modified hr_webcam.css (wider camera viewport)

coveralls · 2015-01-15T12:37:59Z

Coverage remained the same when pulling d247a69 on yoyo2k:8.0 into 1104200 on OCA:8.0.

yvaucher · 2015-01-22T17:06:41Z

@yoyo2k You have some pep8 issues to fix:

./hr_webcam/__init__.py:1:1: E265 block comment should start with '# '
./hr_webcam/__init__.py:8:80: E501 line too long (80 > 79 characters)
./hr_webcam/__openerp__.py:1:1: E265 block comment should start with '# '
./hr_webcam/__openerp__.py:8:80: E501 line too long (80 > 79 characters)
./hr_webcam/hr.py:1:1: F401 'fields' imported but unused
./hr_webcam/hr.py:11:20: E711 comparison to None should be 'if cond is None:'

yoyo2k · 2015-01-22T20:46:10Z

Yeah.. saw those.. I just made minor adjustments to work on 8.0. The rest is unchanged. If needed I'll make the necessary changes to comply to PEP8.

yvaucher · 2015-01-23T08:07:56Z

hr_webcam/__init__.py

@@ -1,12 +1,12 @@
-# -*- coding:utf-8 -*-
+#-*- coding:utf-8 -*-


Why did you changed this line?

This generate a PEP8 error:
./hr_webcam/__init__.py:1:1: E265 block comment should start with '# '

yvaucher · 2015-01-23T08:10:25Z

@yoyo2k As you are porting it, it is the right time to fix those PEP8 issues.

BTW, some errors are due to your changes.

yvaucher · 2015-01-23T08:11:37Z

hr_webcam/__init__.py

-#    it under the terms of the GNU Affero General Public License as published
-#    by the Free Software Foundation, either version 3 of the License, or
+#    it under the terms of the GNU Affero General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or


Please revert this change

./hr_webcam/__init__.py:8:80: E501 line too long (80 > 79 characters)

yoyo2k · 2015-01-23T09:59:14Z

Honest mistake/typo..

coveralls · 2015-01-23T10:05:31Z

Coverage remained the same at 45.45% when pulling 4f443af on yoyo2k:8.0 into 1104200 on OCA:8.0.

yvaucher · 2015-01-23T10:06:57Z

hr_webcam/hr.py

@@ -0,0 +1,24 @@
+from openerp.osv import fields, osv


./hr_webcam/hr.py:1:1: F401 'fields' imported but unused

yvaucher · 2015-01-23T10:09:02Z

Could you also move description from __openerp__.py to README.rst
here is the template:
https://github.com/OCA/maintainers-tools/blob/master/template/module/README.rst

bwrsandman · 2015-02-09T17:30:34Z

There are conflicts in the PR, a rebase may be necessary

- updated __openerp__.py and hr_webcam_view.xml to reflect changes to 8.0 api - modified hr_webcam.css (wider camera viewport)

yoyo2k · 2015-02-24T10:26:10Z

sorry for the long delay.
fixed issues @yvaucher pointed out and rebased repo.

bwrsandman · 2015-02-24T15:43:31Z

hr_expense_sequence/README.rst

+------------
+
+* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
+


Don't you want to add yourself here?

It seems that this PR mixes one of my modules, so he has to remove it, not to attribute it.

true.. because of the rebase..

Closing this pr and opening a new one could fix this.

bwrsandman · 2015-02-24T17:23:35Z

Travis is failing because hr hasn't been renamed in hr_webcam/__init__.py

yoyo2k · 2015-02-25T14:03:11Z

and now? why is it failing?

bwrsandman · 2015-02-25T15:33:32Z

Not sure...

yoyo2k · 2015-02-26T18:15:53Z

Ok.. more than 40 days gone by. I've done everything that was asked. On my system, it works.

yvaucher · 2015-02-27T10:24:08Z

hr_webcam/hr_employee.py

+
+
+class hr_employee(models.Model):
+    _name = 'hr.employee'


Here you wanted to remove _name and not _inherit see https://github.com/yoyo2k/hr/commit/05296ab2269cf4397a5ef25bb3c0dd0074da28a2

yvaucher · 2015-02-27T10:24:46Z

@yoyo2k See my comment I think this is the commit which broke the module (and the tests)

coveralls · 2015-02-27T10:57:20Z

Changes Unknown when pulling 8d55947 on yoyo2k:8.0 into * on OCA:8.0*.

yvaucher · 2015-02-27T11:38:02Z

👍

bwrsandman · 2015-02-27T14:54:18Z

👍

bwrsandman · 2015-03-02T20:22:51Z

Needs a rebase

* up_8.0: Add OCA as author of OCA addons

coveralls · 2015-03-03T10:22:27Z

Coverage decreased (-12.5%) to 50.0% when pulling 365d27f on yoyo2k:8.0 into a222620 on OCA:8.0.

yoyo2k · 2015-03-03T11:03:08Z

fails because of https://github.com/yoyo2k/hr/commit/a222620eefdac771ba6b25bdb57999604fccc4b6

hbrunn · 2015-05-18T07:36:51Z

@yoyo2k fix it for your own file in __openerp__.py as

    'author': "Michael Telahun Makonnen <mmakonnen@gmail.com>,"
    "Odoo Community Association (OCA)",

mdietrichc2c · 2015-06-02T11:59:01Z

@yoyo2k is it possible to modify your __openerp__.py as @hbrunn said? This way, we can give the go-ahead for a merge.

jgrandguillaume · 2015-06-26T13:58:02Z

@yoyo2k Any news here ?

Thanks for the work

ported hr_webcam to 8.0

bwrsandman · 2015-06-26T14:44:21Z

Fixed the small issue and merged manually

aymenrahmaniisims · 2015-12-19T12:55:56Z

just a white picture, my cam is activated but the image be white ?

[BSSFL-124] Move line credit/debit amount calculation from amount_currency

- ported hr_webcam to 8.0

d247a69

- updated __openerp__.py and hr_webcam_view.xml to reflect changes to 8.0 api - modified hr_webcam.css (wider camera viewport)

yvaucher reviewed Jan 23, 2015
View reviewed changes

pep8 compliant

4f443af

yvaucher reviewed Jan 23, 2015
View reviewed changes

hr_webcam/hr.py

@@ -0,0 +1,24 @@

from openerp.osv import fields, osv

Copy link

Member

yvaucher Jan 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./hr_webcam/hr.py:1:1: F401 'fields' imported but unused

added README.rst

8669dd5

yvaucher added 8.0 needs fixing labels Jan 23, 2015

max3903 modified the milestone: 8.0 Feb 14, 2015

max3903 removed the 8.0 label Feb 14, 2015

yoyo2k added 6 commits February 24, 2015 11:56

[FIX] removed fields import

7d51ee7

- ported hr_webcam to 8.0

4e14f01

- updated __openerp__.py and hr_webcam_view.xml to reflect changes to 8.0 api - modified hr_webcam.css (wider camera viewport)

pep8 compliant

5e9ab53

added README.rst

3b59e89

[FIX] removed fields import

e8ddba0

Merge branch '8.0' of https://github.com/yoyo2k/hr into 8.0

cc06dd1

bwrsandman reviewed Feb 24, 2015
View reviewed changes

fixed @bwrsandman 's reqs

05296ab

[FIX] Import hr_employee instead of hr

9d92e4b

improved take picture button

2e5e65e

yvaucher reviewed Feb 27, 2015
View reviewed changes

[FIX] thanks @yvaucher

8d55947

bwrsandman added needs review and removed needs fixing labels Feb 27, 2015

Merge branch 'up_8.0' into 8.0

365d27f

* up_8.0: Add OCA as author of OCA addons

max3903 mentioned this pull request Apr 3, 2015

Migration to version 8 #86

Closed

58 tasks

bwrsandman merged commit 365d27f into OCA:8.0 Jun 26, 2015

bwrsandman pushed a commit that referenced this pull request Jun 26, 2015

Merge pull request #65 from yoyo2k/8.0

31b1f9e

ported hr_webcam to 8.0

bwrsandman removed the needs review label Jun 26, 2015

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

Merge pull request OCA#65 from TelmoSenseFly/BSSFL-124

eb3da67

[BSSFL-124] Move line credit/debit amount calculation from amount_currency

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ported hr_webcam to 8.0 #65

ported hr_webcam to 8.0 #65

yoyo2k commented Jan 15, 2015

coveralls commented Jan 15, 2015

yvaucher commented Jan 22, 2015

yoyo2k commented Jan 22, 2015

yvaucher Jan 23, 2015

yvaucher commented Jan 23, 2015

yvaucher Jan 23, 2015

yoyo2k commented Jan 23, 2015

coveralls commented Jan 23, 2015

yvaucher Jan 23, 2015

yvaucher commented Jan 23, 2015

bwrsandman commented Feb 9, 2015

yoyo2k commented Feb 24, 2015

bwrsandman Feb 24, 2015

pedrobaeza Feb 24, 2015

yoyo2k Feb 24, 2015

yoyo2k Feb 24, 2015

bwrsandman commented Feb 24, 2015

yoyo2k commented Feb 25, 2015

bwrsandman commented Feb 25, 2015

yoyo2k commented Feb 26, 2015

yvaucher Feb 27, 2015

yvaucher commented Feb 27, 2015

coveralls commented Feb 27, 2015

yvaucher commented Feb 27, 2015

bwrsandman commented Feb 27, 2015

bwrsandman commented Mar 2, 2015

coveralls commented Mar 3, 2015

yoyo2k commented Mar 3, 2015

hbrunn commented May 18, 2015

mdietrichc2c commented Jun 2, 2015

jgrandguillaume commented Jun 26, 2015

bwrsandman commented Jun 26, 2015

aymenrahmaniisims commented Dec 19, 2015

		@@ -1,12 +1,12 @@
		# -- coding:utf-8 --
		#-- coding:utf-8 --

		------------

		* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>

ported hr_webcam to 8.0 #65

ported hr_webcam to 8.0 #65

Conversation

yoyo2k commented Jan 15, 2015

coveralls commented Jan 15, 2015

yvaucher commented Jan 22, 2015

yoyo2k commented Jan 22, 2015

Choose a reason for hiding this comment

yvaucher commented Jan 23, 2015

Choose a reason for hiding this comment

yoyo2k commented Jan 23, 2015

coveralls commented Jan 23, 2015

Choose a reason for hiding this comment

yvaucher commented Jan 23, 2015

bwrsandman commented Feb 9, 2015

yoyo2k commented Feb 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwrsandman commented Feb 24, 2015

yoyo2k commented Feb 25, 2015

bwrsandman commented Feb 25, 2015

yoyo2k commented Feb 26, 2015

Choose a reason for hiding this comment

yvaucher commented Feb 27, 2015

coveralls commented Feb 27, 2015

yvaucher commented Feb 27, 2015

bwrsandman commented Feb 27, 2015

bwrsandman commented Mar 2, 2015

coveralls commented Mar 3, 2015

yoyo2k commented Mar 3, 2015

hbrunn commented May 18, 2015

mdietrichc2c commented Jun 2, 2015

jgrandguillaume commented Jun 26, 2015

bwrsandman commented Jun 26, 2015

aymenrahmaniisims commented Dec 19, 2015