Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] hr_attendance_modification_tracking: add manual column pre-install #858

Merged
merged 1 commit into from Jul 9, 2020

Conversation

jarroyomorales
Copy link

Pre init hook and migration script to tackle issue #857

@etobella @js-landoo @ns-landoo @Saran440

@jarroyomorales jarroyomorales force-pushed the 12.0-modification_tracking_column branch from 5d85630 to ec80d11 Compare July 8, 2020 09:54
@jarroyomorales jarroyomorales force-pushed the 12.0-modification_tracking_column branch from ec80d11 to 08fd0f9 Compare July 8, 2020 09:55
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@etobella
Copy link
Member

etobella commented Jul 9, 2020

@OCA/human-resources-maintainers Can you review please, as it is making upgrade hard

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code review

@@ -0,0 +1,14 @@
# Copyright 2020 Creu Blanca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think folder name should be '12.0.1.1.0', because the time_changed_manually field was added in that version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be the destination version where it was implemented, so I think this is fine

@dreispt
Copy link
Sponsor Member

dreispt commented Jul 9, 2020

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-858-by-dreispt-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ed2e634 into OCA:12.0 Jul 9, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3a03484. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants