New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][IMP] hr_attendance_modification_tracking: add manual column pre-install #858
Conversation
5d85630
to
ec80d11
Compare
ec80d11
to
08fd0f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
@OCA/human-resources-maintainers Can you review please, as it is making upgrade hard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 code review
@@ -0,0 +1,14 @@ | |||
# Copyright 2020 Creu Blanca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think folder name should be '12.0.1.1.0', because the time_changed_manually
field was added in that version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version should be the destination version where it was implemented, so I think this is fine
/ocabot merge major |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 3a03484. Thanks a lot for contributing to OCA. ❤️ |
Pre init hook and migration script to tackle issue #857
@etobella @js-landoo @ns-landoo @Saran440